Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Register IInstanceAndEventsRepository #572

Merged
merged 3 commits into from
Nov 28, 2024
Merged

Register IInstanceAndEventsRepository #572

merged 3 commits into from
Nov 28, 2024

Conversation

martinothamar
Copy link
Contributor

Description

Bugfix related to #544

  • Register repo (I had only updated the test fixture)
  • Add the same logic for initializing Created
  • Set InstanceId if not set

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 28, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
38.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@martinothamar martinothamar merged commit 9c637c6 into main Nov 28, 2024
9 checks passed
@martinothamar martinothamar deleted the fix/repo-registration branch November 28, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SandGrainOne SandGrainOne SandGrainOne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martinothamar @SandGrainOne