Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Made calls to npgsql params async and div other sonarcloud suggestions #519

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Made calls to npgsql params async and div other sonarcloud suggestions #519

merged 1 commit into from
Oct 8, 2024

Conversation

HenningNormann
Copy link
Contributor

Description

  • Made calls to npgsql params async
  • Div other sonarcloud suggestions

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

- Made calls to npgsql params async
f61fa4f 
- Div other sonarcloud suggestions
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 7, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
41.7% Coverage on New Code (required ≥ 65%)
0.0% Condition Coverage on New Code (required ≥ 65%)

See analysis details on SonarCloud

@HenningNormann HenningNormann merged commit a96d26e into main Oct 8, 2024
8 of 9 checks passed
@HenningNormann HenningNormann deleted the feature/439-a2-migration-changes-11 branch October 8, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SandGrainOne SandGrainOne SandGrainOne approved these changes

Assignees
No one assigned
Labels
area/data-storage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HenningNormann @SandGrainOne