Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfixes storage postgres interface #254

Closed
wants to merge 33 commits into from
Closed

Bugfixes storage postgres interface #254

wants to merge 33 commits into from

Conversation

HenningNormann
Copy link
Contributor

@HenningNormann HenningNormann commented Aug 30, 2023 •
edited by SandGrainOne
Loading

Fixes since last review. The migration files are kept in the same version to make them more readable until prod convertion. The database is updated manually to support this.

Description

  • Moved all filter logic in GetInstancesFromQuery into the database
  • Added index for partyid lastchanged
  • Changed delete procedures to functions to be able to return row count

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

Henning Normann added 14 commits July 18, 2023 00:45
Moved all filter logic in GetInstancesFromQuery into the database
b8e46b8
- Added index instances_partyid_lastchanged
d29bbdb 
- storage.readinstancefromquery fixes
- Removed postgres stuff from InstanceQueryHelper
- Rewrite of GetInstancesFromQuery
Fix for excludeConfirmedBy
f8ca1cd
- Forced default sort order in GetInstances
6523b1a 
- Restored db functions removed by mistake
- Added /fileScanResult av valid property when updating data element
Added more valid properties to update in data element
931d6cd
Merge from main
801bdab
Ensured that internalId is always sent to dataelement create.
fdd1ce4
Avoid ambigious reference to event
36c7b77
Avoid ambigious reference to event - take 2
d4c9622
Avoid ambigious reference to event - take 3
707537a
Changed delete procedures to functions to be able to return row count.
cd331c6
Fixed ListInstanceEvents
b496c28
Removed duplicate readasync
4ed3f17
Merge from main
7f9de23
github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 30, 2023
View reviewed changes
src/Storage/Repository/PgInstanceRepository.cs
pgcom.Parameters.AddWithValue(NpgsqlDbType.Text, archivedPredicate != null ? queryParams["status.isArchived"].First() : DBNull.Value);
if (_logger.IsEnabled(LogLevel.Debug))
{
_logger.LogDebug(FormatManualFunctionCall(postgresParams));

Check failure

Code scanning / CodeQL

Log entries created from user input High

This log entry depends on a
user-provided value
Loading
.
This log entry depends on a
user-provided value
Loading
.
Added CleanupController and related db logic. Cut-and-paste from exis…
f93972f 
…ting cosmos cleanup and reuse of existing code.
@SandGrainOne
Copy link
Member

There are failing tests.

@sonarcloud
Copy link

sonarcloud bot commented Sep 22, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 46 Code Smells

2.8% 2.8% Coverage
2.1% 2.1% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@HenningNormann HenningNormann mentioned this pull request Nov 27, 2023
Closed
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 28, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 45 Code Smells

2.7% 2.7% Coverage
2.0% 2.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@HenningNormann HenningNormann mentioned this pull request Dec 5, 2023
Merged
5 tasks
@HenningNormann HenningNormann deleted the feature/191-postgresql-poc-4 branch January 22, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acn-sbuad acn-sbuad acn-sbuad left review comments

@SandGrainOne SandGrainOne SandGrainOne left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HenningNormann @SandGrainOne @acn-sbuad