Implement keyword-based dynamic text replacement #657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ords are used in the template.
…ing an order of any type
…alSecurityNumber is set at a time.
…y usage in client code.
…ing national identity and organization numbers
…and national identity numbers.
…ional identity number in the same request.
SandGrainOne
reviewed
Dec 2, 2024
| @@ -13,7 +13,7 @@ | |||
| "EnableDBConnection": true | |||
| }, | |||
| "NotificationConfig": { | |||
| "DefaultEmailFromAddress": "noreply@altinn.no", | |||
| "DefaultEmailFromAddress": "noreply@altinn.cloud", | |||
There was a problem hiding this comment.
This might cause issues in tt02 and production. Make sure we add correct values for those environments in the values file.
There was a problem hiding this comment.
the values.yaml file has the following value:
[email protected] for the environments tt02 and prod.
[email protected] for the environments development, at21, at22, at23, at24 and yt01.
… PartyDetailsLookupRequest class across diverse scenarios.
…re defined as non-nullable.
SandGrainOne
reviewed
Dec 6, 2024
| /// A task that represents the asynchronous operation. | ||
| /// The task result contains a list of <see cref="PartyDetails"/> representing the details of the specified organizations. | ||
| /// </returns> | ||
| public async Task<List<PartyDetails>> GetPartyDetailsForOrganizations(List<string> organizationNumbers) |
There was a problem hiding this comment.
Names lookup allows a mix of organization and national identity numbers in the same request. I think splitting them in separate methods is unnecessary.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces support for placeholder keywords in notification texts, enabling dynamic personalization based on recipient-specific data. These placeholders allow us to dynamically replace predefined keywords in text with the corresponding recipient's information during runtime.
Related Issue(s)
Verification
Documentation