Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Email and SmsPreferred support in Altinn.Notifications.Core #581

Merged
merged 7 commits into from
Aug 5, 2024
Merged

Email and SmsPreferred support in Altinn.Notifications.Core #581

merged 7 commits into from
Aug 5, 2024

Conversation

acn-sbuad
Copy link
Contributor

@acn-sbuad acn-sbuad commented Jul 31, 2024 •
edited
Loading

Description

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@acn-sbuad acn-sbuad changed the title core logic implemented Email and SmsPreferred support in Altinn.Notifications.Core Jul 31, 2024
@acn-sbuad acn-sbuad marked this pull request as ready for review August 1, 2024 08:48
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 5, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
92.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@acn-sbuad acn-sbuad merged commit 5369952 into main Aug 5, 2024
7 checks passed
@acn-sbuad acn-sbuad deleted the feature/541-preferred-core-logic branch August 5, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HenningNormann HenningNormann HenningNormann approved these changes

Assignees
No one assigned
Labels
review/domain-model-changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@acn-sbuad @HenningNormann