Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only copy recipient if lookup is required #528

Merged
merged 1 commit into from
May 28, 2024

Conversation

acn-sbuad
Copy link
Contributor

@acn-sbuad acn-sbuad commented May 28, 2024

Description

Optimizing the code. Currently all recipients are deep copied when completing initial lookup, this is only needed for the users that will be looked up.

Related Issue(s)

  • N/A

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Copy link

sonarcloud bot commented May 28, 2024

Copy link
Member

@tba76 tba76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍺

@acn-sbuad acn-sbuad merged commit a2a6eba into main May 28, 2024
8 checks passed
@acn-sbuad acn-sbuad deleted the chore/avoid-copying-list-if-not-needed branch May 28, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants