Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/508 notification with resource #517

Merged
merged 44 commits into from
May 28, 2024
Merged

Feature/508 notification with resource #517

merged 44 commits into from
May 28, 2024

Conversation

acn-sbuad
Copy link
Contributor

@acn-sbuad acn-sbuad commented May 8, 2024 •
edited
Loading

Description

  • Changed a few model interfaces to base classes to avoid repeating properties.
  • Moved ignoreReservations and resourceId to base class => consequence: the properties will be included in all order endpoints including /status and /notifications. Do we want this, or should I move the properties to the relevant models? Have not made relevant repository changes yet.
  • New profile client to retrieve unit details
  • Updated to contact point service to use both profile client and authorization service

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

acn-sbuad and others added 25 commits May 8, 2024 09:58
@acn-sbuad
Merge branch 'main' into feature/508-notification-with-resource
4752ab8
@acn-sbuad
fixed code smells and duplication
5f65e75
@acn-sbuad
moved serialization out of base class
c3c7811
@acn-sbuad
using find instead of firstordefault
b6fb345
@SandGrainOne
Authorization for multiple users in many organizations
f438b23
@SandGrainOne
Merge appsettings
bc3ba97
@SandGrainOne
Add tests and remove test controller
4bddd5b
@SandGrainOne
Merge branch 'main' into feature/472-Access-filtering-of-recipients
bb92ecd
@SandGrainOne
Replace ContainsKey with TryGetValue
e22f45a
@SandGrainOne
Move authorization interface and service
a876e66
@SandGrainOne
Expand OrganizationContactPoint with personal contact info
1bdf71a
@SandGrainOne
Move test class for AuthorizationService
b6a243b
@SandGrainOne
Rename AuthorizationService to client
4aba2dd
@SandGrainOne
Change input type
62b00d9
@SandGrainOne
Fix comments and settings
777b7ac
@SandGrainOne
Move setup, rename again
35240e8
@SandGrainOne
Change Authorization return type
1b0bb72
@acn-sbuad
merged authorization logic
4973fae
@SandGrainOne
Fixes based on feedback
c8333dd
@SandGrainOne
Move test class AuthorizationServiceTests
8f732b1
@SandGrainOne
Change clone of OrganizationContactPoints
a285c69
@acn-sbuad
current progress
05dac52
@acn-sbuad
Merge branch 'feature/472-Access-filtering-of-recipients' into featur…
d380f7f 
…e/508-notification-with-resource
@acn-sbuad
tests running for profile client
e1db20e
@acn-sbuad
cleaned up k6 file obsolete props
5d01019
@acn-sbuad acn-sbuad marked this pull request as ready for review May 23, 2024 10:14
SandGrainOne
SandGrainOne approved these changes May 24, 2024
View reviewed changes
Copy link
Member

@SandGrainOne SandGrainOne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with some nitpicking.

src/Altinn.Notifications.Core/Integrations/IProfileClient.cs Outdated Show resolved Hide resolved
src/Altinn.Notifications.Integrations/Profile/ProfileClient.cs Outdated Show resolved Hide resolved
src/Altinn.Notifications.Integrations/Profile/ProfileClient.cs Outdated Show resolved Hide resolved
src/Altinn.Notifications/Models/NotificationOrderRequestBaseExt.cs Show resolved Hide resolved
src/Altinn.Notifications/Models/NotificationOrderRequestBaseExt.cs Show resolved Hide resolved
src/Altinn.Notifications/Models/NotificationOrderRequestBaseExt.cs Show resolved Hide resolved
test/Altinn.Notifications.Tests/Notifications.Integrations/Profile/ProfileClientTests.cs Outdated Show resolved Hide resolved
test/Altinn.Notifications.Tests/Notifications.Integrations/Profile/ProfileClientTests.cs Outdated Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 28, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
1 Accepted issue

Measures
0 Security Hotspots
98.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@acn-sbuad acn-sbuad merged commit c01b6d7 into main May 28, 2024
7 checks passed
@acn-sbuad acn-sbuad deleted the feature/508-notification-with-resource branch May 28, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SandGrainOne SandGrainOne SandGrainOne approved these changes

Assignees
No one assigned
Labels
review/domain-model-changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@acn-sbuad @SandGrainOne