Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/439 post order with only nin #469

Merged
merged 15 commits into from
Apr 11, 2024
Merged

Feature/439 post order with only nin #469

merged 15 commits into from
Apr 11, 2024

Conversation

acn-sbuad
Copy link
Contributor

@acn-sbuad acn-sbuad commented Mar 19, 2024 •
edited
Loading

Description

  • Validation for order requests now allows for missing contactpoint (only national identity number)
  • Response object for order request includes lookup result
  • OrderRequestService now includes logic for looking up recipients

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@acn-sbuad acn-sbuad marked this pull request as ready for review April 8, 2024 11:02
tba76
tba76 approved these changes Apr 10, 2024
View reviewed changes
Copy link
Member

@tba76 tba76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍺

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 11, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
95.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@acn-sbuad acn-sbuad merged commit b6a6830 into main Apr 11, 2024
7 checks passed
@acn-sbuad acn-sbuad deleted the feature/439-post-order-with-only-nin branch April 11, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tba76 tba76 tba76 approved these changes

@khanrn khanrn Awaiting requested review from khanrn

@SandGrainOne SandGrainOne Awaiting requested review from SandGrainOne

Assignees
No one assigned
Labels
review/domain-model-changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@acn-sbuad @tba76