Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for registering email delivery report result #461

Merged
merged 2 commits into from
Mar 8, 2024
Merged

Support for registering email delivery report result #461

merged 2 commits into from
Mar 8, 2024

Conversation

acn-sbuad
Copy link
Contributor

@acn-sbuad acn-sbuad commented Mar 7, 2024 •
edited
Loading

Description

  • Updated db enum to reflect values for send result for email and sms
  • Fixed repository logic to update send result for email with/without notification id and operationid
  • Added integration tests

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@acn-sbuad acn-sbuad requested a review from tba76 March 7, 2024 17:00
tba76
tba76 approved these changes Mar 8, 2024
View reviewed changes
Copy link
Member

@tba76 tba76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍺

@acn-sbuad acn-sbuad merged commit 489e2c1 into main Mar 8, 2024
7 checks passed
@acn-sbuad acn-sbuad deleted the feature/email-dr-support branch March 8, 2024 07:58
@acn-sbuad acn-sbuad restored the feature/email-dr-support branch March 8, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tba76 tba76 tba76 approved these changes

Assignees
No one assigned
Labels
review/domain-model-changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@acn-sbuad @tba76