Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calculating sms count based of text lenght and returning number for metrics #459

Merged
merged 6 commits into from
Mar 7, 2024
Merged

Calculating sms count based of text lenght and returning number for metrics #459

merged 6 commits into from
Mar 7, 2024

Conversation

acn-sbuad
Copy link
Contributor

@acn-sbuad acn-sbuad commented Mar 6, 2024 •
edited
Loading

Description

  • Calculating sms count based of concatination rules from Link Mobility on notification creation
  • Updated metrics function to use sms count column to set number of sms for service owner

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@acn-sbuad acn-sbuad changed the title service logic in place for sms count Calculating sms count based of text lenght and returning number for metrics Mar 6, 2024
@acn-sbuad acn-sbuad marked this pull request as ready for review March 6, 2024 14:30
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

tba76
tba76 approved these changes Mar 7, 2024
View reviewed changes
Copy link
Member

@tba76 tba76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍺

@acn-sbuad acn-sbuad merged commit 93d6f26 into main Mar 7, 2024
7 checks passed
@acn-sbuad acn-sbuad deleted the feature/sms-count branch March 7, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tba76 tba76 tba76 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@acn-sbuad @tba76