Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

option to update sms send status with only gateway ref #444

Merged
merged 4 commits into from
Feb 20, 2024

Conversation

acn-sbuad
Copy link
Contributor

@acn-sbuad acn-sbuad commented Feb 19, 2024

Description

When delivery reports are returned for sms, the notificationId is not available, hence it should be possible to update the database with only the gateway reference

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Copy link

sonarcloud bot commented Feb 19, 2024

Copy link
Member

@tba76 tba76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍺

@acn-sbuad acn-sbuad merged commit 43206c5 into main Feb 20, 2024
7 checks passed
@acn-sbuad acn-sbuad deleted the chore/notificationIdoptional branch February 20, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants