Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API endpoint for sms notification summaries #GCPActive #418

Merged
merged 19 commits into from
Feb 9, 2024
Merged

API endpoint for sms notification summaries #GCPActive #418

merged 19 commits into from
Feb 9, 2024

Conversation

acn-sbuad
Copy link
Contributor

@acn-sbuad acn-sbuad commented Feb 7, 2024 •
edited
Loading

Description

API endpoint for getting sms notification summaries added.

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

@acn-sbuad acn-sbuad changed the title Core logic for supporting sms notification summaries API endpoint for sms notification summaries #GCPActive Feb 7, 2024
@acn-sbuad acn-sbuad marked this pull request as draft February 7, 2024 10:50
@acn-sbuad acn-sbuad marked this pull request as ready for review February 8, 2024 10:09
@acn-sbuad acn-sbuad mentioned this pull request Feb 8, 2024
Merged
4 tasks
tba76
tba76 approved these changes Feb 9, 2024
View reviewed changes
Copy link
Member

@tba76 tba76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍺

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@acn-sbuad acn-sbuad merged commit b081211 into main Feb 9, 2024
7 checks passed
@acn-sbuad acn-sbuad deleted the feature/417-api-sms-summary branch February 9, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tba76 tba76 tba76 approved these changes

@SandGrainOne SandGrainOne Awaiting requested review from SandGrainOne

@khanrn khanrn Awaiting requested review from khanrn

Assignees
No one assigned
Labels
review/domain-model-changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@acn-sbuad @tba76