Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using Result instead of tuple where applicable #408

Merged
merged 3 commits into from
Feb 5, 2024
Merged

Using Result instead of tuple where applicable #408

merged 3 commits into from
Feb 5, 2024

Conversation

acn-sbuad
Copy link
Contributor

@acn-sbuad acn-sbuad commented Feb 2, 2024 •
edited
Loading

Description

Removed use of tuples to return success or error response.

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • All tests run green

@acn-sbuad acn-sbuad requested a review from tba76 February 2, 2024 15:38
tba76
tba76 approved these changes Feb 5, 2024
View reviewed changes
Copy link
Member

@tba76 tba76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍺

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 5, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
93.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@acn-sbuad acn-sbuad merged commit 1c61702 into main Feb 5, 2024
7 checks passed
@acn-sbuad acn-sbuad deleted the chore/result-not-tuple branch February 5, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tba76 tba76 tba76 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@acn-sbuad @tba76