Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#351 Core logic for sending SMS to kafka topic #GCPActive #403

Merged
merged 7 commits into from
Feb 2, 2024
Merged

#351 Core logic for sending SMS to kafka topic #GCPActive #403

merged 7 commits into from
Feb 2, 2024

Conversation

acn-sbuad
Copy link
Contributor

@acn-sbuad acn-sbuad commented Jan 31, 2024 •
edited
Loading

Description

  • Logic for passing on new notification to the kafka topic for sending sms

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

@acn-sbuad acn-sbuad changed the title Core logic for sending SMS to kafka topic #393 #393 Core logic for sending SMS to kafka topic Jan 31, 2024
@acn-sbuad acn-sbuad changed the title #393 Core logic for sending SMS to kafka topic #351 Core logic for sending SMS to kafka topic Feb 2, 2024
@acn-sbuad acn-sbuad marked this pull request as ready for review February 2, 2024 09:22
@acn-sbuad acn-sbuad requested a review from tba76 February 2, 2024 09:29
@acn-sbuad acn-sbuad changed the title #351 Core logic for sending SMS to kafka topic #351 Core logic for sending SMS to kafka topic #GCPActive Feb 2, 2024
tba76
tba76 approved these changes Feb 2, 2024
View reviewed changes
Copy link
Member

@tba76 tba76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍺

@acn-sbuad acn-sbuad merged commit 28d9aec into main Feb 2, 2024
2 of 3 checks passed
@acn-sbuad acn-sbuad deleted the feature/351-core-send-sms branch February 2, 2024 11:31
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 2, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

75.0% Condition Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tba76 tba76 tba76 approved these changes

Assignees
No one assigned
Labels
review/domain-model-changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@acn-sbuad @tba76