Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Service logic for creating new sms notification #GCPActive #402

Merged
merged 12 commits into from
Feb 2, 2024
Merged

Service logic for creating new sms notification #GCPActive #402

merged 12 commits into from
Feb 2, 2024

Conversation

tba76
Copy link
Member

@tba76 tba76 commented Jan 30, 2024 •
edited by acn-sbuad
Loading

Description

  • Split orderProcessing services into multiple services, one per communication channel
  • Repostiory logic for retry of order processing
  • Service logic for processing and retrying processing of order.

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
    - [ ] Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

@acn-sbuad acn-sbuad marked this pull request as draft January 31, 2024 09:38
@acn-sbuad acn-sbuad changed the title SmsNotificationServie create notification SmsNotificationServie create notification #GCPActive Jan 31, 2024
@acn-sbuad acn-sbuad changed the title SmsNotificationServie create notification #GCPActive SmsNotificationService create notification #GCPActive Jan 31, 2024
@acn-sbuad acn-sbuad changed the title SmsNotificationService create notification #GCPActive Service logic for creating new sms notification #GCPActive Jan 31, 2024
@acn-sbuad acn-sbuad marked this pull request as ready for review January 31, 2024 13:58
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 2, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
98.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

acn-sbuad
acn-sbuad approved these changes Feb 2, 2024
View reviewed changes
Copy link
Contributor

@acn-sbuad acn-sbuad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎈

@acn-sbuad acn-sbuad merged commit f26e059 into main Feb 2, 2024
7 checks passed
@acn-sbuad acn-sbuad deleted the feature/342-service-logic-sms-create branch February 2, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acn-sbuad acn-sbuad acn-sbuad approved these changes

@SandGrainOne SandGrainOne Awaiting requested review from SandGrainOne

@khanrn khanrn Awaiting requested review from khanrn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tba76 @acn-sbuad