Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#336 Implementation of core logic for placing an sms notification order #380

Merged
merged 24 commits into from
Jan 19, 2024
Merged

#336 Implementation of core logic for placing an sms notification order #380

merged 24 commits into from
Jan 19, 2024

Conversation

khanrn
Copy link
Contributor

@khanrn khanrn commented Jan 16, 2024 •
edited
Loading

This PR is made to implement the core logic for placing an sms notification order described on the issue #336

Description

  • Added SMS channel to NotificationChannel enum.
  • Added SMS notification template type to the NotificationTemplateType enum.
  • Added SMS template(SmsTemplate) to the NotificationTemplate directory.
  • Added JSON subtype(JsonDerivedType) for SMS in the notification interface.
  • Renamed EmailNotificationOrderService and IEmailNotificationOrderService to OrderRequestService and IOrderRequestService.
  • Renamed RegisterEmailNotificationOrder in OrderRequestService to RegisterNotificationOrder.
  • Added default sender number in the config
  • Extended method for setting default value when empty
  • Necessary unit tests added
  • No manual QA would be done as mentioned in the regarding issue that it is not possible as no external endpoints are available

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
    • Except the SonarCloud Code Analysis
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@khanrn khanrn force-pushed the sms/336 branch 4 times, most recently from 913e6b5 to 9e40f09 Compare January 16, 2024 14:11
@khanrn khanrn requested review from acn-sbuad and tba76 January 16, 2024 14:26
@khanrn khanrn self-assigned this Jan 17, 2024
@khanrn khanrn requested a review from acn-sbuad January 17, 2024 11:44
@khanrn khanrn marked this pull request as ready for review January 17, 2024 11:47
@khanrn khanrn requested review from SandGrainOne and tba76 January 18, 2024 08:55
@khanrn
Copy link
Contributor Author

khanrn commented Jan 18, 2024

Had a verbal review from @tba76 to rename _orderService to _orderRequestService.

tba76
tba76 approved these changes Jan 18, 2024
View reviewed changes
Copy link
Member

@tba76 tba76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍺

@SandGrainOne
Copy link
Member

Please try to improve the test coverage a litt bit.

khanrn added 15 commits January 18, 2024 15:50
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 19, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

66.67% Condition Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@khanrn khanrn merged commit 812501d into main Jan 19, 2024
6 of 7 checks passed
@khanrn khanrn deleted the sms/336 branch January 19, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tba76 tba76 tba76 approved these changes

@acn-sbuad acn-sbuad Awaiting requested review from acn-sbuad

@SandGrainOne SandGrainOne Awaiting requested review from SandGrainOne

Assignees

@khanrn khanrn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@khanrn @SandGrainOne @acn-sbuad @tba76