Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded to .NET 8 #315

Merged
merged 1 commit into from
Nov 27, 2023
Merged

Upgraded to .NET 8 #315

merged 1 commit into from
Nov 27, 2023

Conversation

acn-sbuad
Copy link
Contributor

@acn-sbuad acn-sbuad commented Nov 24, 2023

Description

Upgraded application to .NET 8

Related Issue(s)

  • #N/A

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • All tests run green

Copy link

sonarcloud bot commented Nov 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@khanrn
Copy link
Contributor

khanrn commented Nov 24, 2023

Only this test failed in my Mac local testing environment: Altinn.Notifications.Tests.Notifications.Integrations.TestingExtensions.ServiceCollectionExtensionsTests.AddKafkaServices_KafkaSettingsMissing_ThrowsException

Tested with main branch and this branch several times. Reproduced this error every time. Otherwise all the other tests came green.

@acn-sbuad acn-sbuad merged commit e3b6dda into main Nov 27, 2023
9 checks passed
@acn-sbuad acn-sbuad deleted the chore/upgrade-to-net-8 branch November 27, 2023 08:13
@acn-sbuad
Copy link
Contributor Author

Only this test failed in my Mac local testing environment: Altinn.Notifications.Tests.Notifications.Integrations.TestingExtensions.ServiceCollectionExtensionsTests.AddKafkaServices_KafkaSettingsMissing_ThrowsException

Tested with main branch and this branch several times. Reproduced this error every time. Otherwise all the other tests came green.

This is a known unstable test. Unrelated to the upgrade.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants