Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

email notifications endpoint implemented #GCPActive #299

Merged
merged 14 commits into from
Nov 14, 2023
Merged

email notifications endpoint implemented #GCPActive #299

merged 14 commits into from
Nov 14, 2023

Conversation

acn-sbuad
Copy link
Contributor

@acn-sbuad acn-sbuad commented Nov 10, 2023 •
edited
Loading

Description

  • Added repository, core and controller logic for retrieving a summary of a set of email notifications.
  • English descriptions for each result type is added in NotificationsSummaryService in Core.

Implemented the "old" way, let's transition to using result object and change namespaces to match features in a seperate PR to limit cognitive load of the QA process.

Related Issue(s)

Verification

@acn-sbuad acn-sbuad marked this pull request as draft November 10, 2023 12:51
@acn-sbuad acn-sbuad marked this pull request as ready for review November 13, 2023 13:54
tba76
tba76 approved these changes Nov 14, 2023
View reviewed changes
Copy link
Member

@tba76 tba76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍺

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

98.3% 98.3% Coverage
0.0% 0.0% Duplication

@acn-sbuad acn-sbuad merged commit a776357 into main Nov 14, 2023
7 of 8 checks passed
@acn-sbuad acn-sbuad deleted the feature/267-notifiation-list branch November 14, 2023 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tba76 tba76 tba76 approved these changes

@SandGrainOne SandGrainOne Awaiting requested review from SandGrainOne

Assignees
No one assigned
Labels
review/domain-model-changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@acn-sbuad @tba76