Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding support for application owner configuration #257

Closed
wants to merge 17 commits into from
Closed

Adding support for application owner configuration #257

wants to merge 17 commits into from

Conversation

SandGrainOne
Copy link
Member

@SandGrainOne SandGrainOne commented Oct 2, 2023 •
edited
Loading

Description

Adding support for application owner configuration (or preferences). The system should be used when we have a need to approve certain aspects of a notification order. For example the from address in an email or the sender of an SMS.

Added a Result class to replace the use of tuples in cases where a service have the need to return success or failure. Using this for the create email order logic to get a feel for it.

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@SandGrainOne SandGrainOne changed the title Feature/application owner settings Adding support for application owner configuration Oct 2, 2023
@SandGrainOne SandGrainOne marked this pull request as ready for review October 3, 2023 14:56
@sonarcloud
Copy link

sonarcloud bot commented Oct 10, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

78.3% 78.3% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@SandGrainOne
Copy link
Member Author

Postponing work untill we've found a solution to the FromAddress issue.

@SandGrainOne SandGrainOne mentioned this pull request Dec 7, 2023
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acn-sbuad acn-sbuad acn-sbuad left review comments

Assignees
No one assigned
Labels
review/domain-model-changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SandGrainOne @acn-sbuad