Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

from address optional to provide #249

Merged
merged 3 commits into from
Sep 22, 2023
Merged

Conversation

acn-sbuad
Copy link
Contributor

@acn-sbuad acn-sbuad commented Sep 22, 2023

Description

Optional for end user to provide from address, default will be used if nothing is provided

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Copy link
Member

@tba76 tba76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍺

…NotificationsOrderController/EmailNotificationOrdersControllerTests.cs
@sonarcloud
Copy link

sonarcloud bot commented Sep 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@acn-sbuad acn-sbuad merged commit 2927d5a into main Sep 22, 2023
6 checks passed
@acn-sbuad acn-sbuad deleted the feature/246-from-address-optional branch September 22, 2023 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants