Code refactoring

Altinn · Nov 29, 2024 · 62ee16f · 62ee16f
1 parent 26728a0
commit 62ee16f
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 9 deletions.
diff --git a/src/Altinn.Notifications.Core/Models/NotificationTemplate/EmailTemplate.cs b/src/Altinn.Notifications.Core/Models/NotificationTemplate/EmailTemplate.cs
@@ -3,7 +3,7 @@
 namespace Altinn.Notifications.Core.Models.NotificationTemplate;
 
 /// <summary>
-/// Template for an email notification.
+/// Represents a template for an email notification.
 /// </summary>
 public class EmailTemplate : INotificationTemplate
 {
@@ -31,9 +31,9 @@ public class EmailTemplate : INotificationTemplate
     /// Gets the type of the notification template.
     /// </summary>
     /// <value>
-    /// The type of the notification template, represented by the <see cref="NotificationTemplateType" /> enum.
+    /// The type of the notification template, represented by the <see cref="NotificationTemplateType"/> enum.
     /// </value>
-    public NotificationTemplateType Type { get; internal set; } = NotificationTemplateType.Email;
+    public NotificationTemplateType Type { get; } = NotificationTemplateType.Email;
 
     /// <summary>
     /// Initializes a new instance of the <see cref="EmailTemplate"/> class with the specified from address, subject, body, and content type.

diff --git a/src/Altinn.Notifications.Core/Models/NotificationTemplate/SmsTemplate.cs b/src/Altinn.Notifications.Core/Models/NotificationTemplate/SmsTemplate.cs
@@ -3,7 +3,7 @@
 namespace Altinn.Notifications.Core.Models.NotificationTemplate;
 
 /// <summary>
-/// Template for an SMS notification.
+/// Represents a template for an SMS notification.
 /// </summary>
 public class SmsTemplate : INotificationTemplate
 {
@@ -21,9 +21,9 @@ public class SmsTemplate : INotificationTemplate
     /// Gets the type of the notification template.
     /// </summary>
     /// <value>
-    /// The type of the notification template, represented by the <see cref="NotificationTemplateType" /> enum.
+    /// The type of the notification template, represented by the <see cref="NotificationTemplateType"/> enum.
     /// </value>
-    public NotificationTemplateType Type { get; internal set; } = NotificationTemplateType.Sms;
+    public NotificationTemplateType Type { get; } = NotificationTemplateType.Sms;
 
     /// <summary>
     /// Initializes a new instance of the <see cref="SmsTemplate"/> class with the specified sender number and body.

diff --git a/test/Altinn.Notifications.IntegrationTests/Utils/TestdataUtil.cs b/test/Altinn.Notifications.IntegrationTests/Utils/TestdataUtil.cs
@@ -65,7 +65,6 @@ public static NotificationOrder NotificationOrder_EmailTemplate_OneRecipient()
             {
                 new EmailTemplate()
                 {
-                    Type = NotificationTemplateType.Email,
                     FromAddress = "[email protected]",
                     Subject = "email-subject",
                     Body = "email-body",
@@ -105,7 +104,6 @@ public static NotificationOrder NotificationOrder_SmsTemplate_OneRecipient()
             {
                 new SmsTemplate()
                 {
-                    Type = NotificationTemplateType.Sms,
                     Body = "sms-body",
                     SenderNumber = "Altinn local test"
                 }

diff --git a/test/Altinn.Notifications.Tests/Notifications.Core/TestingModels/NotificationOrderTests.cs b/test/Altinn.Notifications.Tests/Notifications.Core/TestingModels/NotificationOrderTests.cs
@@ -31,7 +31,6 @@ public NotificationOrderTests()
             {
                  new EmailTemplate()
                  {
-                     Type = NotificationTemplateType.Email,
                      FromAddress = "[email protected]",
                      Subject = "email-subject",
                      Body = "email-body",