Get system register dto fix not visible #939
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
acn-dgopa
reviewed
Dec 12, 2024
| @@ -91,6 +96,13 @@ public async Task<ActionResult<RequestSystemResponse>> CreateRequest([FromBody] | |||
| SystemId = createRequest.SystemId, | |||
| }; | |||
|
|
|||
| SystemUser? existing = await _systemUserRepository.GetSystemUserByExternalRequestId(externalRequestId); | |||
There was a problem hiding this comment.
Why are we calling the repository directly? we usually route via the service
acn-dgopa
reviewed
Dec 12, 2024
| @@ -91,6 +96,13 @@ public async Task<ActionResult<RequestSystemResponse>> CreateRequest([FromBody] | |||
| SystemId = createRequest.SystemId, | |||
| }; | |||
|
|
|||
| SystemUser? existing = await _systemUserRepository.GetSystemUserByExternalRequestId(externalRequestId); | |||
| if (existing is not null) | |||
| { | |||
There was a problem hiding this comment.
we follow a different error pattern in other controllers if i remember
mgunnerud
reviewed
Dec 12, 2024
| @@ -68,7 +73,7 @@ public async Task<ActionResult<RegisteredSystemDTO>> GetRegisteredSystemDto(stri | |||
| { | |||
| RegisteredSystem registeredSystem = await _systemRegisterService.GetRegisteredSystemInfo(systemId, cancellationToken); | |||
|
|
|||
| if (registeredSystem == null) | |||
| if (registeredSystem == null || !registeredSystem.IsVisible) | |||
There was a problem hiding this comment.
I think this will break the bff and frontend? For vendorrequest and change request, in GET, the request only contains the systemId. The bff uses this service (authentication/api/v1/systemregister/{systemId}) to load the system (for displaying orgno, vendorname, systemname).
An alternative solution for this is for backend to include the system object in GET vendorrequest and change request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue(s)
Verification
Documentation