Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redirect to systemuser redirectUrl after approving/rejecting change request #927

Merged
merged 6 commits into from
Dec 6, 2024
Merged

Redirect to systemuser redirectUrl after approving/rejecting change request #927

merged 6 commits into from
Dec 6, 2024

Conversation

mgunnerud
Copy link
Contributor

@mgunnerud mgunnerud commented Dec 5, 2024 •
edited
Loading

Description

  • On logout, check if cookie AltinnLogoutInfo contains SystemuserChangeRequestId value. If it does, look up redirectUrl from systemuser change request and redirect to this url

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@mgunnerud mgunnerud linked an issue Dec 5, 2024 that may be closed by this pull request
Handle redirect to system after approve/reject change request #926
Closed
1 task
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

simen-rekkedal
simen-rekkedal approved these changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@simen-rekkedal simen-rekkedal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@mgunnerud mgunnerud merged commit 7be2a21 into main Dec 6, 2024
9 checks passed
@mgunnerud mgunnerud deleted the chore/changerequest-logout branch December 6, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simen-rekkedal simen-rekkedal simen-rekkedal approved these changes

@TheTechArch TheTechArch Awaiting requested review from TheTechArch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handle redirect to system after approve/reject change request
2 participants
@mgunnerud @simen-rekkedal