Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sr persistance layer 1 #382

Merged
merged 54 commits into from
Feb 1, 2024
Merged

Sr persistance layer 1 #382

merged 54 commits into from
Feb 1, 2024

Conversation

simen-rekkedal
Copy link
Contributor

New Persistance layer for SystemUser

Description

Wrote yuniql migration scripts to create schema, grants, tables and functions.
Wrote Insert new SystemUser function.

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@simen-rekkedal simen-rekkedal self-assigned this Nov 15, 2023
@simen-rekkedal simen-rekkedal marked this pull request as draft November 15, 2023 09:12
@simen-rekkedal
SQL fixes after testing in PgAdmin
4870b32
@simen-rekkedal
Read functions
893bc48
@simen-rekkedal
more Functions
6da05c0
@simen-rekkedal
small fixes
ecde9bc
@simen-rekkedal
Rewrite to inline C# sql instead of Yunicle SQL migration files
089afb8
@simen-rekkedal
Create DependencyInjection.cs
14c6f13
@simen-rekkedal
RegisteredSystem Repository
709782a
@simen-rekkedal
interface
69d94c9
@simen-rekkedal
More methods in Repository
52338b3
@simen-rekkedal
Update SystemUserRespository.cs
efe3a8c
@simen-rekkedal
postgres sql
18071c0
@simen-rekkedal
Update SystemRegisterRepository.cs
7cac4c1
@simen-rekkedal
System Register Postgres SQL
5c17b99
@simen-rekkedal
Update SystemRegisterRepository.cs
b5cb66b
@simen-rekkedal
fixes
ff2ed29
@simen-rekkedal
Refactoring
9dbb004 
Refactored started, added Core project.
Added some Postgres Testcontainer logic
Fixed some Postgres SQL
@simen-rekkedal
Merge branch 'main' into SR_Persistance_Layer_1
2b71f7d
@simen-rekkedal
fixes to DI
b1ae698
@simen-rekkedal
Merge branch 'SR_Persistance_Layer_1' of https://github.com/Altinn/al…
d13469b 
…tinn-authentication into SR_Persistance_Layer_1
@simen-rekkedal
TestContainer Tests
d109731
@simen-rekkedal simen-rekkedal marked this pull request as ready for review January 9, 2024 14:13
@simen-rekkedal simen-rekkedal marked this pull request as draft January 16, 2024 09:01
@simen-rekkedal simen-rekkedal marked this pull request as ready for review January 16, 2024 09:53
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 16, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

This was referenced Jan 16, 2024
Closed
Closed
acn-dgopa
acn-dgopa approved these changes Jan 23, 2024
View reviewed changes
Copy link
Member

@acn-dgopa acn-dgopa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we discussed, you can see the possibility on using dependency injection class for mock data setup in development environment

src/Authentication/Controllers/SystemUserController.cs Show resolved Hide resolved
src/Authentication/Controllers/SystemUserController.cs Show resolved Hide resolved
src/Authentication/Services/Interfaces/ISystemUserService.cs Show resolved Hide resolved
src/Authentication/Services/SystemUserService.cs Show resolved Hide resolved
src/Core/Models/SystemUser.cs Show resolved Hide resolved
src/Core/Models/SystemUserRequestDTO.cs Show resolved Hide resolved
src/Core/Models/SystemUserUpdateDTO.cs Show resolved Hide resolved
src/Persistance/RepositoryImplementations/SystemRegisterRepository.cs Show resolved Hide resolved
@simen-rekkedal simen-rekkedal merged commit 9562088 into main Feb 1, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acn-dgopa acn-dgopa acn-dgopa approved these changes

Assignees

@simen-rekkedal simen-rekkedal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simen-rekkedal @acn-dgopa