Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/e2e playwright systemuser 433 #442

Merged
merged 16 commits into from
Dec 4, 2024

Conversation

Nyeng
Copy link
Contributor

@Nyeng Nyeng commented Nov 29, 2024

Description

Related Issue(s)

  • Playwrighttester for Systembruker #433

  • Sette Slack-webhook url som secret repo variable: 'SLACK_WEBHOOK_URL' (Spør meg) @TheTechArch har du mulighet til å legge til her?

  • Hvilke miljøer? Foreslår AT22 og TT02 i første omgang, så kan vi legge på AT23 og 24 dersom de funker etter hvert.

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

Litt dumt at jeg navnga Slack-appen "api-e2e-tests" da jeg satte det opp for APItestene, men ja... tanker?

https://digdir.slack.com/archives/C082EFA1N73/p1732902313180839

@Nyeng Nyeng requested a review from mgunnerud November 29, 2024 17:48
@Nyeng Nyeng marked this pull request as ready for review December 1, 2024 20:06
frontend/playwright/pages/systemUserPage.ts Outdated Show resolved Hide resolved
@Nyeng Nyeng dismissed mgunnerud’s stale review December 4, 2024 14:59

Made the needed changes, not sure why its not marked as resolved?

@Nyeng
Copy link
Contributor Author

Nyeng commented Dec 4, 2024

@mgunnerud skal ha resolva og gjort endringene som trengs her nå (var en kommentar jeg ikke fikk resolva eller noe så prøvde å ignore review, så må nok godkjennes på nytt)

@Nyeng Nyeng merged commit f1d003d into main Dec 4, 2024
5 checks passed
@Nyeng Nyeng deleted the feature/e2e-playwright-systemuser-433 branch December 4, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants