Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove delegationcheck #440

Merged
merged 32 commits into from
Dec 5, 2024
Merged

Remove delegationcheck #440

merged 32 commits into from
Dec 5, 2024

Conversation

mgunnerud
Copy link
Contributor

@mgunnerud mgunnerud commented Nov 28, 2024 •
edited
Loading

Description

  • Remove delegationcheck and related code (will be done in authentication backend instead)
  • Add mapping for error messages from authentication backend
  • Add translations for delegation-related error messages

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@mgunnerud
remove delegation check + use new create endpoint WIP
b1311bc
@mgunnerud
remove dead code
d8ab825
@mgunnerud
add problemDetails mapper
ee417f0
@mgunnerud
fix warnings + remove dead code
136d364
@mgunnerud
fix warning
7eca096
@mgunnerud
fix merge conflict
c1e9c3e
@mgunnerud
Merge remote-tracking branch 'origin/main' into chore/remove-delegati…
c42c687 
…oncheck
@mgunnerud
return 404 if request is not found
38abd34
@mgunnerud
show specific error message for request id not found
6b03937
@mgunnerud
fix return type
fe54a05
@mgunnerud
add translations for delegation errors
18c6dec
@mgunnerud
move parameter to pathname
a0f74d1
@mgunnerud
fix texts
112e03f
@mgunnerud
remove PDP mock + old dependencies
7efef63
@mgunnerud
improve msw mock code + change mock to typescript
230e9c6
@mgunnerud
fix after change in backend
725b044
@mgunnerud
merge med main
9cdcddb
@mgunnerud
update problem mapping
ada3387
@mgunnerud
fix merge conflicts
f92be43
@mgunnerud
fixes
d5821a9
@mgunnerud
temp test fix
5e5f6f8
@mgunnerud
minor size change
4d10610
@mgunnerud mgunnerud linked an issue Nov 28, 2024 that may be closed by this pull request
Add more specific error messages when creation of system user fails #427
Closed
simen-rekkedal
simen-rekkedal approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@simen-rekkedal simen-rekkedal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mgunnerud mgunnerud merged commit b5f38af into main Dec 5, 2024
5 checks passed
@mgunnerud mgunnerud deleted the chore/remove-delegationcheck branch December 5, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simen-rekkedal simen-rekkedal simen-rekkedal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add more specific error messages when creation of system user fails
2 participants
@mgunnerud @simen-rekkedal