Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/amui/1101 unhappy flow ikke alle rettigheter delegert #1137

Merged

Conversation

sonwit
Copy link
Contributor

@sonwit sonwit commented Nov 1, 2024

Description

  • Handle errors and partially failed delegations.
  • Fix snackbar
  • Add alert for screen-readers
  • Adding some storybook test-data
  • Refactor MSW handlers

note:

It's difficult to test the functionality of a partially failing delegation without real-world data. My hypothesis is that it will look more accurate once we have access to actual data. Invalid data will then be refreshed, and the modal will display the current state. Currently, these changes are not displayed, which might lead to an unexpected user experience.

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@github-actions github-actions bot added the kind/feature-request Used when issue is a new feature or request label Nov 1, 2024
@sonwit sonwit requested a review from allinox November 1, 2024 13:18
Copy link
Contributor

@allinox allinox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 😄

I agree that the intended user experience is hard to display with only static test data. It will likely be a lot better once invalidating cache gives us an actually updated state based on the action the user just performed. But this is the best we can do for now, I think. We'll just have to make sure it all works as intended once we get the backend online as well.

src/localizations/no_nb.json Outdated Show resolved Hide resolved
src/localizations/no_nb.json Show resolved Hide resolved
Copy link

sonarqubecloud bot commented Nov 4, 2024

@sonwit sonwit merged commit f59fcd0 into main Nov 4, 2024
8 checks passed
@sonwit sonwit deleted the feat/amui/1101-Unhappy-flow-ikke-alle-rettigheter-delegert branch November 4, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature-request Used when issue is a new feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants