Make path optional #1143
Merged
Make path optional #1143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdesmet
force-pushed
the
fix/path-optional
branch
from
c056407 to
8667d1a
Compare
|
@AdiGajbhiye , @saravmajestic: Can we assess the impact of making this change. What will be the effect on documentation editor, project health check and lineage. |
just by looking at the changes, tests added as macros will be affected. I will test the doc editor and will let you know |
mdesmet
commented
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Problem
Packages folder is not downloaded on dbt cloud, so we can't resolve the path to any dbt entities located there.
Solution
Make path optional
Screenshot/Demo
A picture is worth a thousand words. Please highlight the changes if applicable.
How to test
Checklist
README.mdupdated and added information about my change