Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

query panel migration revamp #1093

Merged
merged 43 commits into from
May 31, 2024
Merged

query panel migration revamp #1093

merged 43 commits into from
May 31, 2024

Conversation

saravmajestic
Copy link
Collaborator

@saravmajestic saravmajestic commented Apr 30, 2024 •
edited
Loading

Overview

Problem

  • Migrate query results panel to webview react

Solution

  • migrated required components and functionalities to webview components
  • fixed query cancel issue (applies for existing query panel)
  • fixed switching to query results panel if a query is triggered before panel render is completed (applies for existing query panel)
  • alternative colors for the rows in perspective table
  • Added QueryPanelV2Activated telemetry event if activated and QueryPanelV2Deactivated if deactivated

Screenshot/Demo

image

How to test

  • Load the extension
  • enable dbt.enableQueryPanelV2 in vscode settings
  • switch to a model and exectute the model. Should be able to see latest panel

Checklist

  • I have run this code and it appears to resolve the stated issue
  • README.md updated and added information about my change

@saravmajestic saravmajestic marked this pull request as ready for review April 30, 2024 11:51
AdiGajbhiye
AdiGajbhiye reviewed May 3, 2024
View reviewed changes
src/dbt_client/dbtCoreIntegration.ts
return new QueryExecution(
async () => {
queryThread.kill(2);
},
async () => {
await this.createPythonDbtProject(queryThread);
await queryThread.ex`project.init_project()`;
Copy link
Collaborator

@AdiGajbhiye AdiGajbhiye May 3, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i am not sure about this change. will the project be in usable state if we kill thread during init_project

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't matter as this is not affecting main thread.

AdiGajbhiye
AdiGajbhiye approved these changes May 3, 2024
View reviewed changes
Copy link
Collaborator

@AdiGajbhiye AdiGajbhiye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

This was linked to issues May 30, 2024
Query Results Horizontal Scroll Bar Hides at Low Heights #1172
Closed
first query per session shows the settings page #1081
Closed
@anandgupta42 anandgupta42 changed the title Feat/query panel migration query panel migration revamp May 31, 2024
@anandgupta42 anandgupta42 merged commit 5b830b2 into master May 31, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdiGajbhiye AdiGajbhiye AdiGajbhiye approved these changes

@mdesmet mdesmet mdesmet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Query Results Horizontal Scroll Bar Hides at Low Heights first query per session shows the settings page
4 participants
@saravmajestic @mdesmet @AdiGajbhiye @anandgupta42