Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add manifest onboard cli #9

Merged
merged 12 commits into from
Feb 12, 2024
Merged

feat: Add manifest onboard cli #9

merged 12 commits into from
Feb 12, 2024

Conversation

gaurpulkit
Copy link
Contributor

No description provided.

suryaiyer95
suryaiyer95 reviewed Feb 5, 2024
View reviewed changes
Copy link
Collaborator

@suryaiyer95 suryaiyer95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments

suryaiyer95
suryaiyer95 reviewed Feb 6, 2024
View reviewed changes
src/datapilot/core/platforms/dbt/cli/cli.py Outdated
click.echo("Error: API Token is required.")
return

# if not validate_credentials(token, tenant):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do this

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/AltimateAI/altimate-backend/blob/main/app/api/dbt_v3.py#L137

@suryaiyer95 suryaiyer95 requested a review from mdesmet February 7, 2024 19:13
suryaiyer95
suryaiyer95 approved these changes Feb 12, 2024
View reviewed changes
Copy link
Collaborator

@suryaiyer95 suryaiyer95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@suryaiyer95 suryaiyer95 merged commit 8885392 into main Feb 12, 2024
102 checks passed
@anandgupta42 anandgupta42 deleted the manifest-onboarding branch April 22, 2024 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suryaiyer95 suryaiyer95 suryaiyer95 approved these changes

@mdesmet mdesmet Awaiting requested review from mdesmet

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gaurpulkit @suryaiyer95