feat: add dbt 1.8 support #35
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaurpulkit
commented
May 22, 2024
| from datapilot.core.platforms.dbt.constants import GENERIC | ||
| from datapilot.core.platforms.dbt.constants import SINGULAR | ||
|
|
||
| ManifestNode = Union[ |
There was a problem hiding this comment.
RPCNode which was present in v11 isn't available here
gaurpulkit
commented
May 22, 2024
| docs=seed.docs.dict() if seed.docs else None, | ||
| patch_path=seed.patch_path, | ||
| build_path=seed.build_path, | ||
| deferred=False, # seed.deferred isn't present in ManifestV12 |
There was a problem hiding this comment.
@suryaiyer95 deferred isn't available in v12
|
tests seem to be failing : E UserWarning: Field "model_unique_id" has conflict with protected namespace "model_". |
suryaiyer95
reviewed
May 27, 2024
| raw_code, | ||
| language, | ||
| contract, | ||
| ) = ([], [], None, None, None, None, None, "", "", None) |
There was a problem hiding this comment.
Did you do? Not readable this way
There was a problem hiding this comment.
Better to put None. As list is mutable, wierd things can happen
suryaiyer95
reviewed
May 31, 2024
| @@ -8,7 +8,7 @@ def generate_ci_cd_report(insights_data): | |||
| for insight in insights_data: | |||
| print(divider) | |||
| print(f"Project: {insight.package_name}") | |||
| print(f"Model ID: {insight.model_unique_id}") | |||
| print(f"Model ID: {insight.altimate_unique_id}") | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.