Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Handle eslint warnings #5253

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

amanape
Copy link
Member

@amanape amanape commented Nov 25, 2024

End-user friendly description of the problem this fixes or functionality that this introduces
The CI use to complain due to a few ESLint warnings (mostly console logs)

  • Include this change in the Release Notes. If checked, you must provide an end-user friendly description for your change below

Give a summary of what the PR does, explaining any non-trivial design decisions

  • Replace console.errors with our EventLogger.error to avoid eslint warning; we should handle the request errors when implementing axios in the future
  • Remove yarn.lock

Link of any specific issues this addresses


To run this PR locally, use the following command:

docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:dc4848f-nikolaik   --name openhands-app-dc4848f   docker.all-hands.dev/all-hands-ai/openhands:dc4848f

@amanape amanape self-assigned this Nov 25, 2024
@amanape amanape marked this pull request as ready for review November 25, 2024 07:41
frontend/.eslintrc Outdated Show resolved Hide resolved
@amanape amanape requested a review from rbren November 27, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants