-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue #5015: [Bug]: Headless mode awaits for requested user feedb… #5246
base: main
Are you sure you want to change the base?
Conversation
…ack without showing any text for what that feedback should be
The PR you are fixing is: #5246 Read all its contents before starting. |
…ted user feedb…
@openhands-agent End-user friendly description of the problem this fixes or functionality that this introduces: Explain what this PR does When the app is running in headless mode, it must not ask the user for input. This means two things:
Read the comments in the original issue: you will find an example of how headless mode is implemented silently in external scripts. |
…ted user feedb…
openhands-agent, the previous comments were mostly solved. We have a few more things to do now:
|
…ted user feedb…
@openhands-agent Python linting is failing on this PR in CI. You know how to run python linting in this project. Fix it and commit the fix. |
…ted user feedb…
The workflow to fix this issue encountered an error. Please check the workflow logs for more information. |
@openhands-agent Look carefully at the diff of this PR. Undo the exact changes you made to traffic control. Only those, and commit; the rest is fine. |
…ted user feedb…
End-user friendly description of the problem this fixes or functionality that this introduces
Headless mode must not stop to ask the user for input.
Explain what this PR does
When the app is running in headless mode, it must not ask the user for input. This means two things:
Read the comments in the original issue: you will find an example of how headless mode is implemented silently in external scripts.
You have a unit test for headless mode set. Read it and fix it to conform to this behavior. Then add a test for headless mode not set.
Link of any specific issues this addresses
Fix #5015
To run this PR locally, use the following command: