Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) Update logs after run_action (EventStreamRuntime) #3870

Merged
merged 1 commit into from
Sep 15, 2024
Merged

Conversation

tobitege
Copy link
Collaborator

Short description of the problem this fixes or functionality that this introduces. This may be used for the CHANGELOG

No longer defer container logs after runtime run_action (EventStreamRuntime)


Give a summary of what the PR does, explaining any non-trivial design decisions

  • the container logs were not directly updated after a run_command in the EventStreamRuntime
  • this caused a "lagging" of logs showing in dev terminal

Issue is easy to reproduce:

  • in File Explorer click different files (which can be displayed in the Code Editor)
  • observe that their content appears on the next click in the terminal's docker logs, not immediately after

Link of any specific issues this addresses

@tobitege tobitege requested review from xingyaoww and enyst September 14, 2024 21:19
@tobitege tobitege added the enhancement New feature or request label Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants