Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cron mode & retryUpdateCronHpaStatus #112

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

LivingCcj
Copy link

add cron mode & retryUpdateCronHpaStatus

@ringtail
Copy link
Member

ringtail commented Sep 1, 2022

Could you explain what is cron mode.

@LivingCcj
Copy link
Author

cronMode : controller cron job work or not work.
Enable: means cron job is work normal.
Disable: means cron job is not work (set cron mode when upgrade service or stop cronhpa but not delete it).

@ringtail
Copy link
Member

ringtail commented Sep 8, 2022

cronMode : controller cron job work or not work. Enable: means cron job is work normal. Disable: means cron job is not work (set cron mode when upgrade service or stop cronhpa but not delete it).

What's is the scene?

@LivingCcj
Copy link
Author

base scene : cronhpa -> deployment
when you upgrade deployment, the cronhpa will attack the upgrade operation, so it should skip this cron job.
meanwhile cronhpa -> hpa -> deployment

@ringtail
Copy link
Member

ringtail commented Sep 9, 2022

when you upgrade deployment, the cronhpa will attack the upgrade operation, so it should skip this cron job.

Do you mean cronhpa is in a very tiny duration?

@LivingCcj
Copy link
Author

when you upgrade deployment, the cronhpa will attack the upgrade operation, so it should skip this cron job.

Do you mean cronhpa is in a very tiny duration?

if deployment type is Rolling update,cron job will disturb the procedure of rolling. there would take some risk

@ringtail
Copy link
Member

Would skip this time and retry later be better for this case?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants