[Common,DPG] PID: Add AO2D metadata handling for pass name in TPC CCDB calls (pull/6793), adding NN-version number , using nSigmaTOFdautrack in protons from Lambda decays #8835
+63
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…DB calls (pull/6793), adding NN-version number , using nSigmaTOFdautrack in protons from Lambda decays
…ave this metadata tag
amaringarcia
requested review from
alibuild,
chiarazampolli,
alcaliva,
catalinristea,
jgrosseo,
iarsene,
ktf,
ddobrigk and
a team
as code owners
github-actions
bot
changed the title
|
@alcaliva @chiarazampolli could you have a look at this pull request. It is important for the TPC dE/dx. In the test that it failed, I only see warnings. I think I can ignor them, or? |
chiarazampolli
approved these changes
Dec 6, 2024
|
Hello @amaringarcia , To me it looks ok, but you have to fix the issues with the linter test for sure. I am not an expert about it, though, I guess that warnings are a problem. Chiara |
|
Dear all, all "required" tests are successful. Can one approve and "merge" this request? Changing so many names int the pidTPC I find it "risky". |
njacazio
approved these changes
Dec 9, 2024
|
For the Common part @ddobrigk has to approve |
|
@ddobrigk can you have a look? I think your approval is needed. |
ddobrigk
approved these changes
Dec 10, 2024
Archita-Dash
pushed a commit
to Archita-Dash/O2Physics
that referenced
this pull request
Dec 11, 2024
…B calls (pull/6793), adding NN-version number , using nSigmaTOFdautrack in protons from Lambda decays (AliceO2Group#8835)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.