Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PWGHF,PWGJE] Declare common derived tables with macros #8780

Merged
merged 3 commits into from
Dec 3, 2024
Merged

[PWGHF,PWGJE] Declare common derived tables with macros #8780

merged 3 commits into from
Dec 3, 2024
+193 −350

Conversation

nzardosh
Copy link
Collaborator

@nzardosh nzardosh commented Dec 2, 2024

No description provided.

@github-actions github-actions bot changed the title declare common derived tables with macros and rename 3P and common tables [PWGHF] declare common derived tables with macros and rename 3P and common tables Dec 2, 2024
@alibuild
Copy link
Collaborator

alibuild commented Dec 2, 2024

Error while checking build/O2Physics/o2 for 649bbfa at 2024-12-02 21:42:

## sw/BUILD/O2Physics-latest/log
/sw/slc9_x86-64/O2/daily-20241202-0000-local1/include/Framework/AnalysisHelpers.h:48:33: error: static assertion failed: Argument number mismatch
/sw/slc9_x86-64/O2/daily-20241202-0000-local1/include/Framework/AnalysisHelpers.h:50:11: error: no match for call to '(o2::framework::{anonymous}::memfun_type<void (o2::framework::TableBuilder::persist<float, float, float>(const std::array<const char*, 3>&)::<lambda(unsigned int, o2::framework::BuilderMaker<float>::FillType, o2::framework::BuilderMaker<float>::FillType, o2::framework::BuilderMaker<float>::FillType)>::*)(unsigned int, float, float, float) const>::type {aka std::function<void(unsigned int, float, float, float)>}) (int, const float&, const float&, const float&, const float&)'
ninja: build stopped: subcommand failed.

Full log here.

@vkucera vkucera changed the title [PWGHF] declare common derived tables with macros and rename 3P and common tables [PWGHF] Declare common derived tables with macros and rename 3P and common tables Dec 2, 2024
vkucera
vkucera previously approved these changes Dec 2, 2024
View reviewed changes
@vkucera vkucera enabled auto-merge (squash) December 2, 2024 23:52
@alibuild
Copy link
Collaborator

alibuild commented Dec 3, 2024

Error while checking build/O2Physics/o2 for 7291bba at 2024-12-03 01:01:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/8780-slc9_x86-64/0/PWGJE/DataModel/JetSubtraction.h:57:58: error: 'Hf3PBases' does not name a type; did you mean 'HfLcPBases'?
/sw/SOURCES/O2Physics/8780-slc9_x86-64/0/PWGJE/DataModel/JetSubtraction.h:57:1: error: 'binding_t' does not name a type
/sw/SOURCES/O2Physics/8780-slc9_x86-64/0/PWGJE/DataModel/JetSubtraction.h:57:1: error: 'binding_t' was not declared in this scope
/sw/SOURCES/O2Physics/8780-slc9_x86-64/0/PWGJE/DataModel/JetSubtraction.h:57:1: error: no matching function for call to 'o2::aod::bkglc::CandidateId::candidate_as<<expression error> >() const'
/sw/SOURCES/O2Physics/8780-slc9_x86-64/0/PWGJE/DataModel/JetSubtraction.h:57:1: error: template argument 1 is invalid
/sw/SOURCES/O2Physics/8780-slc9_x86-64/0/PWGJE/DataModel/JetSubtraction.h:57:1: error: 'binding_t' was not declared in this scope
/sw/SOURCES/O2Physics/8780-slc9_x86-64/0/PWGJE/DataModel/JetSubtraction.h:62:58: error: 'Hf3PPBases' does not name a type; did you mean 'HfLcPBases'?
/sw/SOURCES/O2Physics/8780-slc9_x86-64/0/PWGJE/DataModel/JetSubtraction.h:62:1: error: 'binding_t' does not name a type
/sw/SOURCES/O2Physics/8780-slc9_x86-64/0/PWGJE/DataModel/JetSubtraction.h:62:1: error: 'binding_t' was not declared in this scope
/sw/SOURCES/O2Physics/8780-slc9_x86-64/0/PWGJE/DataModel/JetSubtraction.h:62:1: error: no matching function for call to 'o2::aod::bkglcmc::CandidateId::candidate_as<<expression error> >() const'
/sw/SOURCES/O2Physics/8780-slc9_x86-64/0/PWGJE/DataModel/JetSubtraction.h:62:1: error: template argument 1 is invalid
/sw/SOURCES/O2Physics/8780-slc9_x86-64/0/PWGJE/DataModel/JetSubtraction.h:62:1: error: 'binding_t' was not declared in this scope
/sw/SOURCES/O2Physics/8780-slc9_x86-64/0/PWGJE/DataModel/Jet.h:182:51: error: 'Hf3PBases' does not name a type; did you mean 'HfLcPBases'?
/sw/SOURCES/O2Physics/8780-slc9_x86-64/0/PWGJE/DataModel/Jet.h:107:5: error: 'binding_t' does not name a type
/sw/SOURCES/O2Physics/8780-slc9_x86-64/0/PWGJE/DataModel/Jet.h:107:5: error: 'binding_t' was not declared in this scope
/sw/SOURCES/O2Physics/8780-slc9_x86-64/0/PWGJE/DataModel/Jet.h:107:5: error: no matching function for call to 'o2::aod::LcChargedjetconstituents::CandidatesIds::candidates_as<<expression error> >() const'
/sw/SOURCES/O2Physics/8780-slc9_x86-64/0/PWGJE/DataModel/Jet.h:107:5: error: template argument 1 is invalid
/sw/SOURCES/O2Physics/8780-slc9_x86-64/0/PWGJE/DataModel/Jet.h:107:5: error: 'binding_t' was not declared in this scope
/sw/SOURCES/O2Physics/8780-slc9_x86-64/0/PWGJE/DataModel/Jet.h:107:5: error: no matching function for call to 'o2::aod::LcChargedjetconstituents::CandidatesIds::candidates_first_as<<expression error> >() const'
/sw/SOURCES/O2Physics/8780-slc9_x86-64/0/PWGJE/DataModel/Jet.h:107:5: error: template argument 1 is invalid
/sw/SOURCES/O2Physics/8780-slc9_x86-64/0/PWGJE/DataModel/Jet.h:107:5: error: 'binding_t' was not declared in this scope
/sw/SOURCES/O2Physics/8780-slc9_x86-64/0/PWGJE/DataModel/Jet.h:107:5: error: no matching function for call to 'o2::aod::LcChargedjetconstituents::CandidatesIds::candidates_last_as<<expression error> >() const'
/sw/SOURCES/O2Physics/8780-slc9_x86-64/0/PWGJE/DataModel/Jet.h:107:5: error: template argument 1 is invalid
/sw/SOURCES/O2Physics/8780-slc9_x86-64/0/PWGJE/DataModel/Jet.h:107:5: error: 'binding_t' was not declared in this scope
/sw/SOURCES/O2Physics/8780-slc9_x86-64/0/PWGJE/DataModel/Jet.h:182:51: error: 'Hf3PBases' does not name a type; did you mean 'HfLcPBases'?
/sw/SOURCES/O2Physics/8780-slc9_x86-64/0/PWGJE/DataModel/Jet.h:107:5: error: 'binding_t' does not name a type
/sw/SOURCES/O2Physics/8780-slc9_x86-64/0/PWGJE/DataModel/Jet.h:107:5: error: 'binding_t' was not declared in this scope
/sw/SOURCES/O2Physics/8780-slc9_x86-64/0/PWGJE/DataModel/Jet.h:107:5: error: no matching function for call to 'o2::aod::LcChargedMCDetectorLeveljetconstituents::CandidatesIds::candidates_as<<expression error> >() const'
/sw/SOURCES/O2Physics/8780-slc9_x86-64/0/PWGJE/DataModel/Jet.h:107:5: error: template argument 1 is invalid
/sw/SOURCES/O2Physics/8780-slc9_x86-64/0/PWGJE/DataModel/Jet.h:107:5: error: 'binding_t' was not declared in this scope
/sw/SOURCES/O2Physics/8780-slc9_x86-64/0/PWGJE/DataModel/Jet.h:107:5: error: no matching function for call to 'o2::aod::LcChargedMCDetectorLeveljetconstituents::CandidatesIds::candidates_first_as<<expression error> >() const'
/sw/SOURCES/O2Physics/8780-slc9_x86-64/0/PWGJE/DataModel/Jet.h:107:5: error: template argument 1 is invalid
/sw/SOURCES/O2Physics/8780-slc9_x86-64/0/PWGJE/DataModel/Jet.h:107:5: error: 'binding_t' was not declared in this scope
/sw/SOURCES/O2Physics/8780-slc9_x86-64/0/PWGJE/DataModel/Jet.h:107:5: error: no matching function for call to 'o2::aod::LcChargedMCDetectorLeveljetconstituents::CandidatesIds::candidates_last_as<<expression error> >() const'
/sw/SOURCES/O2Physics/8780-slc9_x86-64/0/PWGJE/DataModel/Jet.h:107:5: error: template argument 1 is invalid
/sw/SOURCES/O2Physics/8780-slc9_x86-64/0/PWGJE/DataModel/Jet.h:107:5: error: 'binding_t' was not declared in this scope
/sw/SOURCES/O2Physics/8780-slc9_x86-64/0/PWGJE/DataModel/Jet.h:182:62: error: 'Hf3PPBases' does not name a type; did you mean 'HfLcPBases'?
/sw/SOURCES/O2Physics/8780-slc9_x86-64/0/PWGJE/DataModel/Jet.h:107:5: error: 'binding_t' does not name a type
/sw/SOURCES/O2Physics/8780-slc9_x86-64/0/PWGJE/DataModel/Jet.h:107:5: error: 'binding_t' was not declared in this scope
/sw/SOURCES/O2Physics/8780-slc9_x86-64/0/PWGJE/DataModel/Jet.h:107:5: error: no matching function for call to 'o2::aod::LcChargedMCParticleLeveljetconstituents::CandidatesIds::candidates_as<<expression error> >() const'
/sw/SOURCES/O2Physics/8780-slc9_x86-64/0/PWGJE/DataModel/Jet.h:107:5: error: template argument 1 is invalid
/sw/SOURCES/O2Physics/8780-slc9_x86-64/0/PWGJE/DataModel/Jet.h:107:5: error: 'binding_t' was not declared in this scope
/sw/SOURCES/O2Physics/8780-slc9_x86-64/0/PWGJE/DataModel/Jet.h:107:5: error: no matching function for call to 'o2::aod::LcChargedMCParticleLeveljetconstituents::CandidatesIds::candidates_first_as<<expression error> >() const'
/sw/SOURCES/O2Physics/8780-slc9_x86-64/0/PWGJE/DataModel/Jet.h:107:5: error: template argument 1 is invalid
/sw/SOURCES/O2Physics/8780-slc9_x86-64/0/PWGJE/DataModel/Jet.h:107:5: error: 'binding_t' was not declared in this scope
/sw/SOURCES/O2Physics/8780-slc9_x86-64/0/PWGJE/DataModel/Jet.h:107:5: error: no matching function for call to 'o2::aod::LcChargedMCParticleLeveljetconstituents::CandidatesIds::candidates_last_as<<expression error> >() const'
/sw/SOURCES/O2Physics/8780-slc9_x86-64/0/PWGJE/DataModel/Jet.h:107:5: error: template argument 1 is invalid
/sw/SOURCES/O2Physics/8780-slc9_x86-64/0/PWGJE/DataModel/Jet.h:107:5: error: 'binding_t' was not declared in this scope
[0 more errors; see full log]

Full log here.

@alibuild
Copy link
Collaborator

alibuild commented Dec 3, 2024

Error while checking build/O2Physics/o2 for 838e92d at 2024-12-03 08:54:

## sw/BUILD/O2Physics-latest/log
/sw/slc9_x86-64/O2/daily-20241203-0000-local1/include/Framework/AnalysisHelpers.h:48:33: error: static assertion failed: Argument number mismatch
/sw/slc9_x86-64/O2/daily-20241203-0000-local1/include/Framework/AnalysisHelpers.h:50:11: error: no match for call to '(o2::framework::{anonymous}::memfun_type<void (o2::framework::TableBuilder::persist<float, float, float, float>(const std::array<const char*, 4>&)::<lambda(unsigned int, o2::framework::BuilderMaker<float>::FillType, o2::framework::BuilderMaker<float>::FillType, o2::framework::BuilderMaker<float>::FillType, o2::framework::BuilderMaker<float>::FillType)>::*)(unsigned int, float, float, float, float) const>::type {aka std::function<void(unsigned int, float, float, float, float)>}) (int, const float&, const float&, const float&)'
ninja: build stopped: subcommand failed.

Full log here.

@github-actions github-actions bot added the pwgje label Dec 3, 2024
@nzardosh nzardosh changed the title [PWGHF] Declare common derived tables with macros and rename 3P and common tables [PWGHF] Declare common derived tables with macros Dec 3, 2024
@nzardosh nzardosh changed the title [PWGHF] Declare common derived tables with macros [PWGHF, PWGJE] Declare common derived tables with macros Dec 3, 2024
@github-actions github-actions bot changed the title [PWGHF, PWGJE] Declare common derived tables with macros [PWGHF,PWGJE] Declare common derived tables with macros Dec 3, 2024
@vkucera vkucera disabled auto-merge December 3, 2024 09:22
@vkucera vkucera enabled auto-merge (squash) December 3, 2024 09:23
@nzardosh nzardosh enabled auto-merge (squash) December 3, 2024 09:24
alibuild
alibuild approved these changes Dec 3, 2024
View reviewed changes
Copy link
Collaborator

@alibuild alibuild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @nzardosh.

@nzardosh nzardosh merged commit 9d81b96 into AliceO2Group:master Dec 3, 2024
15 of 19 checks passed
@nzardosh nzardosh deleted the bjets branch December 3, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkucera vkucera vkucera approved these changes

@alibuild alibuild alibuild approved these changes

@fcolamar fcolamar Awaiting requested review from fcolamar fcolamar is a code owner

@fgrosa fgrosa Awaiting requested review from fgrosa fgrosa is a code owner

@fcatalan92 fcatalan92 Awaiting requested review from fcatalan92 fcatalan92 is a code owner

@mfaggin mfaggin Awaiting requested review from mfaggin mfaggin is a code owner

@mmazzilli mmazzilli Awaiting requested review from mmazzilli mmazzilli is a code owner

@deepathoms deepathoms Awaiting requested review from deepathoms deepathoms is a code owner

@NicoleBastid NicoleBastid Awaiting requested review from NicoleBastid NicoleBastid is a code owner

@hahassan7 hahassan7 Awaiting requested review from hahassan7 hahassan7 is a code owner

@jpxrk jpxrk Awaiting requested review from jpxrk jpxrk is a code owner

@apalasciano apalasciano Awaiting requested review from apalasciano apalasciano is a code owner

@maoyx maoyx Awaiting requested review from maoyx maoyx is a code owner

@fjonasALICE fjonasALICE Awaiting requested review from fjonasALICE fjonasALICE is a code owner

@mfasDa mfasDa Awaiting requested review from mfasDa mfasDa is a code owner

@mhemmer-cern mhemmer-cern Awaiting requested review from mhemmer-cern mhemmer-cern is a code owner

Assignees
No one assigned
Labels
datamodel pwghf PWG-HF pwgje
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nzardosh @alibuild @vkucera