[PWGCF] Updated CorrSparse with added histograms and a changed dPhi definition #8770
+26
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
changed the title
[PWGCF] Please consider the following formatting changes to AliceO2Group#8770
victor-gonzalez
previously approved these changes
Dec 2, 2024
I updated to use the o2::constants::math
Removed Configurables I don't use
Tried fixing the lint issues
|
I have troubleshooted the lint errors and can't find the solution, it seems to be the same setup as the previous accepted file. For some reason it causes issues now. Please let me know if you have any suggestions. |
| @@ -33,12 +37,8 @@ struct CorrSparse { | |||
| Configurable<float> cfgPtCutMin = {"minpt", 0.2, "Minimum accepted track pT. Default 0.2 GeV"}; | |||
There was a problem hiding this comment.
For this one, for example, you have to change it to
Configurable<float> cfgPtCutMin = {"cfgPtCutMin", 0.2, "Minimum accepted track pT. Default 0.2 GeV"};
to get rid of the error in that line
Similar for the similar errors
|
|
||
| // define the filtered collisions and tracks | ||
|
|
||
| using aodCollisions = soa::Filtered<soa::Join<aod::Collisions, aod::EvSels, aod::CentFT0Cs>>; |
There was a problem hiding this comment.
For this one, as suggested, you have to use UpperCamelCase, i.e. AodCollisions
And similar for the similar ones
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.