Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[O2B-1366] Fixed user starting/stopping runs not being properly extracted #1806

Merged

Conversation

martinboulais
Copy link
Collaborator

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:

  • N/A

Notable changes for developers:

  • Fixed users that start/stop runs not being extracted from kafka message

Changes made to the database:

  • N/A

Copy link

codecov bot commented Dec 2, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 43.76%. Comparing base (8ce02ce) to head (b89c883).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
lib/server/kafka/AliEcsSynchronizer.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1806      +/-   ##
==========================================
- Coverage   43.78%   43.76%   -0.02%     
==========================================
  Files         893      893              
  Lines       15959    15954       -5     
  Branches     3005     3003       -2     
==========================================
- Hits         6987     6983       -4     
+ Misses       8972     8971       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martinboulais martinboulais force-pushed the mboulais/O2B-1366/actualy-extract-user-that-start-stop-run branch from a2c9f99 to 2eadf73 Compare December 2, 2024 20:14
graduta
graduta previously approved these changes Dec 3, 2024
@martinboulais martinboulais merged commit 3009b9b into main Dec 3, 2024
23 checks passed
@martinboulais martinboulais deleted the mboulais/O2B-1366/actualy-extract-user-that-start-stop-run branch December 3, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants