Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[O2B-1401] Store runs and QC flags timestamps with ms #1795

Merged

Conversation

martinboulais
Copy link
Collaborator

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:

  • N/A

Notable changes for developers:

  • Runs and QC flags timestamps now store milliseconds

Changes made to the database:

  • Following columns in runs table has been changed to Datetime(3):
    • time_o2_start
    • time_trg_start
    • first_tf_timestamp
    • last_tf_timestamp
    • time_trg_end
    • time_o2_end
  • Following columns in quality_control_flags table has been changed to Datetime(3):
    • from
    • to
    • created_at
    • updated_at
  • Following columns in quality_control_flag_effective_periods table has been changed to Datetime(3):
    • from
    • to
    • created_at
    • updated_at

@martinboulais martinboulais added the bug Something isn't working label Nov 5, 2024
@martinboulais martinboulais self-assigned this Nov 5, 2024
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.78%. Comparing base (78e987e) to head (033b79a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1795      +/-   ##
==========================================
+ Coverage   43.77%   43.78%   +0.01%     
==========================================
  Files         893      893              
  Lines       15956    15959       +3     
  Branches     3003     3005       +2     
==========================================
+ Hits         6984     6987       +3     
  Misses       8972     8972              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martinboulais martinboulais merged commit 4e9f479 into main Nov 27, 2024
23 checks passed
@martinboulais martinboulais deleted the mboulais/O2B-1401/store-runs-and-qcflags-timestamps-with-ms branch November 27, 2024 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging this pull request may close these issues.

2 participants