merge prev

AliceO2Group · Aug 1, 2024 · b8f2fd4 · b8f2fd4
2 parents 599472b + 8111374
commit b8f2fd4
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/test/public/defaults.js b/test/public/defaults.js
@@ -157,6 +157,16 @@ const waitForTableToLength = async (page, expectedSize) => {
 
 module.exports.waitForTableLength = waitForTableToLength;
 
+/**
+ * Waits for table to be loaded
+ *
+ * @param {puppeteer.Page} page - The puppeteer page where the table is located.
+ * @return {Promise<void>} resolves once the table is loaded
+ */
+const waitForTableToBeLoaded = async (page) => page.waitForSelector('table tbody tr:not(.loading-row):not(.empty-row)');
+
+module.exports.waitForTableToBeLoaded = waitForTableToBeLoaded;
+
 /**
  * Wait for the total number of elements to be the expected one
  *

diff --git a/test/public/qcFlags/gaqOverview.test.js b/test/public/qcFlags/gaqOverview.test.js
@@ -24,6 +24,7 @@ const {
     getPopoverInnerText,
     setConfirmationDialogToBeAccepted,
     unsetConfirmationDialogActions,
+    waitForTableToBeLoaded,
 } = require('../defaults.js');
 
 const { expect } = chai;
@@ -72,7 +73,7 @@ module.exports = () => {
 
         await validateTableData(page, new Map(Object.entries(tableDataValidators)));
 
-        await page.waitForSelector('tr:nth-of-type(2)');
+        await waitForTableToBeLoaded(page);
         expect(await getTableContent(page)).to.have.all.deep.ordered.members([
             [
                 'MC.R',
@@ -108,6 +109,7 @@ module.exports = () => {
         await waitForNavigation(page, () => pressElement(page, 'h2:nth-of-type(2) a', true));
         await waitForNavigation(page, () => pressElement(page, '#row106-globalAggregatedQuality a', true));
 
+        await waitForTableToBeLoaded(page);
         expect(await getTableContent(page)).to.have.all.deep.ordered.members([
             [
                 'good',