a

AliceO2Group · Nov 19, 2024 · 5880df0 · 5880df0
1 parent baa9bda
commit 5880df0
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 4 deletions.
diff --git a/lib/server/services/qualityControlFlag/QcFlagService.js b/lib/server/services/qualityControlFlag/QcFlagService.js
@@ -726,14 +726,17 @@ class QcFlagService {
         summaryUnit[QC_SUMMARY_PROPERTIES.mcReproducible] =
             mcReproducible || summaryUnit[QC_SUMMARY_PROPERTIES.mcReproducible];
 
-        if (summaryUnit[QC_SUMMARY_PROPERTIES.qualityNotDefinedEffectiveRunCoverage] === undefined) {
-            summaryUnit[QC_SUMMARY_PROPERTIES.qualityNotDefinedEffectiveRunCoverage] = 0;
+        if (summaryUnit[QC_SUMMARY_PROPERTIES.explicitlyNotBadEffectiveRunCoverage] === undefined) {
+            summaryUnit[QC_SUMMARY_PROPERTIES.explicitlyNotBadEffectiveRunCoverage] = 0;
         }
         if (summaryUnit[QC_SUMMARY_PROPERTIES.badEffectiveRunCoverage] === undefined) {
             summaryUnit[QC_SUMMARY_PROPERTIES.badEffectiveRunCoverage] = 0;
         }
-        if (summaryUnit[QC_SUMMARY_PROPERTIES.explicitlyNotBadEffectiveRunCoverage] === undefined) {
-            summaryUnit[QC_SUMMARY_PROPERTIES.explicitlyNotBadEffectiveRunCoverage] = 0;
+        if (summaryUnit[QC_SUMMARY_PROPERTIES.qualityNotDefinedEffectiveRunCoverage] === undefined) {
+            summaryUnit[QC_SUMMARY_PROPERTIES.qualityNotDefinedEffectiveRunCoverage] = 1 - (
+                summaryUnit[QC_SUMMARY_PROPERTIES.badEffectiveRunCoverage] +
+                summaryUnit[QC_SUMMARY_PROPERTIES.explicitlyNotBadEffectiveRunCoverage]
+            );
         }
     }
 

diff --git a/test/lib/server/services/qualityControlFlag/QcFlagService.test.js b/test/lib/server/services/qualityControlFlag/QcFlagService.test.js
@@ -152,12 +152,14 @@ module.exports = () => {
                         mcReproducible: true,
                         badEffectiveRunCoverage: 0.3333,
                         explicitlyNotBadEffectiveRunCoverage: 0,
+                        qualityNotDefinedEffectiveRunCoverage: 0.6667000000000001,
                     },
                     16: {
                         badEffectiveRunCoverage: 0,
                         explicitlyNotBadEffectiveRunCoverage: 1,
                         mcReproducible: false,
                         missingVerificationsCount: 1,
+                        qualityNotDefinedEffectiveRunCoverage: 0,
                     },
                 },
             });
@@ -171,12 +173,14 @@ module.exports = () => {
                         mcReproducible: true,
                         badEffectiveRunCoverage: 0.1111,
                         explicitlyNotBadEffectiveRunCoverage: 0.2222,
+                        qualityNotDefinedEffectiveRunCoverage: 0.7778,
                     },
                     16: {
                         badEffectiveRunCoverage: 0,
                         explicitlyNotBadEffectiveRunCoverage: 1,
                         mcReproducible: false,
                         missingVerificationsCount: 1,
+                        qualityNotDefinedEffectiveRunCoverage: 0,
                     },
                 },
             });
@@ -215,6 +219,7 @@ module.exports = () => {
                         mcReproducible: false,
                         badEffectiveRunCoverage: 0.0769,
                         explicitlyNotBadEffectiveRunCoverage: 0,
+                        qualityNotDefinedEffectiveRunCoverage: 0.9231,
                     },
                 },
             });
@@ -249,6 +254,7 @@ module.exports = () => {
                         mcReproducible: false,
                         badEffectiveRunCoverage: 0.7222,
                         explicitlyNotBadEffectiveRunCoverage: 0,
+                        qualityNotDefinedEffectiveRunCoverage: 0.27780000000000005,
                     },
                 },
             });
@@ -267,6 +273,7 @@ module.exports = () => {
                         mcReproducible: false,
                         badEffectiveRunCoverage: 0.1667,
                         explicitlyNotBadEffectiveRunCoverage: 0.8333,
+                        qualityNotDefinedEffectiveRunCoverage: 0.16669999999999996,
                     },
 
                     // ITS