additional tasks by Krivoruchko Dmitry #24

UmbrellaLeaf5 · 2024-11-23T17:25:20Z

No description provided.

…ngly_connected_component

…component

github-actions

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 15 out of 38. Check the log or trigger a new build to see more.

additional_tasks/chem_experiments_chain/src/tarjan_algorithm.hpp

additional_tasks/graph/src/main.cpp

additional_tasks/graph/src/test.cpp

additional_tasks/petya_and_vasya_labyrinth/src/a_star.hpp

lib/src/graph/edge.cpp

lib/src/graph/for_size_t/edge.cpp

lib/src/graph/for_size_t/graph_construct.cpp

lib/src/graph/for_string/edge.cpp

lib/src/graph/for_string/graph_construct.cpp

github-actions

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 15 out of 33. Check the log or trigger a new build to see more.

additional_tasks/chem_experiments_chain/src/tarjan_algorithm.hpp

additional_tasks/petya_and_vasya_labyrinth/src/main.cpp

additional_tasks/petya_and_vasya_labyrinth/src/petya_and_vasya_labyrinth.hpp

lib/src/graph/for_integral/edge.cpp

lib/src/graph/for_integral/graph_construct.cpp

lib/src/graph/graph.hpp

github-actions

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 15 out of 25. Check the log or trigger a new build to see more.

additional_tasks/chem_experiments_chain/src/tarjan_algorithm.hpp

additional_tasks/petya_and_vasya_labyrinth/src/main.cpp

additional_tasks/petya_and_vasya_labyrinth/src/petya_and_vasya_labyrinth.hpp

lib/src/graph/for_integral/edge.cpp

lib/src/graph/for_integral/graph_construct.cpp

lib/src/graph/graph.hpp

github-actions

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 15 out of 16. Check the log or trigger a new build to see more.

additional_tasks/chem_experiments_chain/src/tarjan_algorithm.hpp

additional_tasks/petya_and_vasya_labyrinth/src/petya_and_vasya_labyrinth.hpp

lib/src/graph/for_integral/edge.cpp

lib/src/graph/for_integral/graph_construct.cpp

lib/src/graph/for_string/edge.cpp

lib/src/graph/graph.hpp

github-actions

clang-tidy made some suggestions

github-actions · 2024-11-29T20:20:00Z

additional_tasks/chem_experiments_chain/src/tarjan_algorithm.hpp

+ * алгоритму Тарьяна.
+ * @tparam vert_t: тип вершин
+ * @tparam weight_t: тип весов
+ * @param graph: исходный граф


warning: avoid do-while loops [cppcoreguidelines-avoid-do-while]

do { ^

github-actions · 2024-11-29T20:20:00Z

additional_tasks/petya_and_vasya_labyrinth/src/petya_and_vasya_labyrinth.hpp

+inline PetyaAndVasyaGraphs ParseMaze(
+    std::istream& is = std::cin,
+    SolutionType sol_type = SolutionType::ComplicatedBad) {
+  Graph<std::string, long> graph;


warning: enum 'SolutionType' uses a larger base type ('int', size: 4 bytes) than necessary for its value set, consider using 'std::uint8_t' (1 byte) as the base type to reduce its size [performance-enum-size]

a; ^

github-actions · 2024-11-29T20:20:00Z

lib/src/graph/for_integral/edge.cpp

+
+template <AllowedVertType vert_t, AllowedWeightType weight_t>
+const std::string& Graph<vert_t, weight_t>::Edge::Name() const {
+  static std::string name;


warning: variable 'name' of type 'std::string' (aka 'basic_string') can be declared 'const' [misc-const-correctness]

Suggested change

static std::string name;

static std::string const name;

github-actions · 2024-11-29T20:20:00Z

lib/src/graph/for_integral/graph_construct.cpp

+  return Graph(edges);
+}
+
+template <AllowedVertType vert_t, AllowedWeightType weight_t>


warning: constructor does not initialize these fields: edges_, verts_ [cppcoreguidelines-pro-type-member-init]

template <AllowedVertType vert_t, AllowedWeightType weight_t> ^

github-actions · 2024-11-29T20:20:00Z

lib/src/graph/for_string/edge.cpp

+
+template <AllowedVertType vert_t, AllowedWeightType weight_t>
+const std::string& Graph<vert_t, weight_t>::Edge::Name() const {
+  static std::string name;


warning: variable 'name' of type 'std::string' (aka 'basic_string') can be declared 'const' [misc-const-correctness]

lib/src/graph/for_string/edge.cpp:7:

- name; + const name;

github-actions · 2024-11-29T20:20:01Z

lib/src/graph/graph.hpp

+  template class Graph<std::string, short>;  \
+  template class Graph<std::string, int>;    \
+  template class Graph<std::string, long>;   \
+  template class Graph<std::string, size_t>; \


warning: constructor does not initialize these fields: start_vert_, end_vert_ [cppcoreguidelines-pro-type-member-init]

lib/src/graph/graph.hpp:405:

- private: - end_vert_; + private: + end_vert_;{}{}

github-actions · 2024-11-29T20:20:01Z

lib/src/graph/graph.hpp

+  template class Graph<std::string, long>;   \
+  template class Graph<std::string, size_t>; \
+  template class Graph<std::string, float>;  \
+  template class Graph<std::string, double>; \


warning: constructor does not initialize these fields: start_vert_, end_vert_ [cppcoreguidelines-pro-type-member-init]

{end_vert} {} ^

github-actions · 2024-11-29T20:20:01Z

lib/src/graph/graph.hpp

+  template class Graph<std::string, long double>
+
+#define GRAPH_TEMPLATE_CONSTRUCT_FOR_INTEGRAL \
+  template class Graph<char, char>;           \


warning: constructor does not initialize these fields: start_vert_, end_vert_ [cppcoreguidelines-pro-type-member-init]

eight} {} ^

github-actions · 2024-11-29T20:20:01Z

lib/src/graph/graph.hpp

+#define GRAPH_TEMPLATE_CONSTRUCT_FOR_INTEGRAL \
+  template class Graph<char, char>;           \
+  template class Graph<char, short>;          \
+  template class Graph<char, int>;            \


warning: constructor does not initialize these fields: start_vert_, end_vert_ [cppcoreguidelines-pro-type-member-init]

t}, end_vert_{edge_pair.second} {} ^

github-actions · 2024-11-29T20:20:01Z

lib/src/graph/graph_methods.cpp

+bool Graph<vert_t, weight_t>::IsWeighted() const {
+  if (edges_.empty()) return false;
+
+  bool is_weighted = true;


warning: variable 'is_weighted' of type 'bool' can be declared 'const' [misc-const-correctness]

Suggested change

bool is_weighted = true;

alse;const

…eString_

github-actions

clang-tidy made some suggestions

additional_tasks/chem_experiments_chain/src/tarjan_algorithm.hpp

additional_tasks/petya_and_vasya_labyrinth/src/petya_and_vasya_labyrinth.hpp

lib/src/graph/for_integral/edge.cpp

lib/src/graph/for_integral/graph_construct.cpp

lib/src/graph/for_string/edge.cpp

lib/src/graph/graph.hpp

lib/src/graph/graph_methods.cpp

UmbrellaLeaf5 added 30 commits September 7, 2024 10:28

delete extra extension from docker

9cfcf59

update format CMakeLists

39f8a8f

update lib folder

aa962ae

update lib->utils name in CMakeLists

6e59658

Merge remote-tracking branch 'upstream/main'

b5d47d1

README beautify

ae45494

add graph_additional_task

6032727

docker file back

bcd54e5

update edge.Name()

5230994

update class Graph with unordered_map as AdjList

cf04922

update names and comments

4c939f8

Merge remote-tracking branch 'upstream/main' into graph_additional_task

ff9397f

CMakeLists hotfix

1ccac8e

Merge remote-tracking branch 'origin/graph_additional_task' into stro…

64008e7

…ngly_connected_component

move graph to lib

3976ff9

Merge remote-tracking branch 'upstream/main' into strongly_connected_…

04c762f

…component

Merge remote-tracking branch 'upstream/main' into graph_additional_task

b85a801

and const

ffa9925

create folder

4e8ea35

finish primary realization

b9d5975

fix mistakes

c47cb73

update README.md and add comments

4fa263b

add tests

8691cba

move graph class to lib

b224e5b

create folder for dag_relaxation

4ddb11c

add topological_sort from task_01

6bfef24

primary complete dag_relaxation

ffd686d

add more exception throwing

fb1cbba

code beautify

0919619

fix typo

f737732

UmbrellaLeaf5 added 7 commits November 23, 2024 20:15

Merge branch 'dag_relaxation_additional_task' into additional_tasks

ce2993f

rename algorithms folders to tasks names

609b741

rename: start_vert -> start in DAGRelaxation

7a14ed6

add AStar primary realization

380efe7

optimize AStar: remove non_visited_verts

c87ebc8

code beautify

c2b29aa

update comments

b7fda02

UmbrellaLeaf5 force-pushed the additional_tasks branch from 76ba3b2 to 9c969a3 Compare November 25, 2024 16:28

UmbrellaLeaf5 added 3 commits November 25, 2024 21:17

add GoodSolution and its maze parsing

5a1efed

update tests

5d4385a

update README.md

b600b27

UmbrellaLeaf5 force-pushed the additional_tasks branch from 33e6be7 to b600b27 Compare November 25, 2024 18:17

update comments in graph class and add move constructor

a67d809

github-actions bot reviewed Nov 29, 2024

View reviewed changes

update graph class: allow negative weight and add more template types

cbe81d7

github-actions bot reviewed Nov 29, 2024

View reviewed changes

fix bugs in methods in class graph connected with undirected graph

dfe0bfe

github-actions bot reviewed Nov 29, 2024

View reviewed changes

complete GitHub suggestions

e5fa95a

github-actions bot reviewed Nov 29, 2024

View reviewed changes

code beautify

1097fec

github-actions bot reviewed Nov 29, 2024

View reviewed changes

UmbrellaLeaf5 added 2 commits December 7, 2024 12:53

rename: GetWeightOfEdge -> GetEdgeWeight, ParseEdgeString -> ParseEdg…

fc5f0d2

…eString_

add graph class methods: GetEdgeIter, SetEdgeWeight

6d560f1

github-actions bot reviewed Dec 8, 2024

View reviewed changes

UmbrellaLeaf5 force-pushed the additional_tasks branch from f877b9b to 0ea5cd4 Compare December 8, 2024 14:59

move all methods in graph class to graph.hpp

5761e70

UmbrellaLeaf5 force-pushed the additional_tasks branch from 0ea5cd4 to 5761e70 Compare December 8, 2024 15:00

UmbrellaLeaf5 added 2 commits December 8, 2024 18:07

move graph.hpp and utils.hpp to .. folder

efa50c7

update graph class (code simplify and beautify)

33130a9

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

additional tasks by Krivoruchko Dmitry #24

additional tasks by Krivoruchko Dmitry #24

UmbrellaLeaf5 commented Nov 23, 2024

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot Nov 29, 2024

github-actions bot Nov 29, 2024

github-actions bot Nov 29, 2024

github-actions bot Nov 29, 2024

github-actions bot Nov 29, 2024

github-actions bot Nov 29, 2024

github-actions bot Nov 29, 2024

github-actions bot Nov 29, 2024

github-actions bot Nov 29, 2024

github-actions bot Nov 29, 2024

github-actions bot left a comment

additional tasks by Krivoruchko Dmitry #24

Are you sure you want to change the base?

additional tasks by Krivoruchko Dmitry #24

Conversation

UmbrellaLeaf5 commented Nov 23, 2024

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Nov 29, 2024

Choose a reason for hiding this comment

github-actions bot Nov 29, 2024

Choose a reason for hiding this comment

github-actions bot Nov 29, 2024

Choose a reason for hiding this comment

github-actions bot Nov 29, 2024

Choose a reason for hiding this comment

github-actions bot Nov 29, 2024

Choose a reason for hiding this comment

github-actions bot Nov 29, 2024

Choose a reason for hiding this comment

github-actions bot Nov 29, 2024

Choose a reason for hiding this comment

github-actions bot Nov 29, 2024

Choose a reason for hiding this comment

github-actions bot Nov 29, 2024

Choose a reason for hiding this comment

github-actions bot Nov 29, 2024

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment