Reran new models after Catlab update. #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on with a different hom import, renamed a variable in sir_linear_stratification. Overall, things worked pretty well.
|
@Xiaoyan-Li Please have a look. Example models all work here. |
…omp in new diabetes_diagnose
Thank you very much!! The examples all look great! Only have a quick question: What is the difference between the two examples: diabetes_diagnose and sir_linear... seems are all about the diabetes stratified models? Should we combine those two examples to be one? Or at least I may suggest modify the "sir_linear... " example's name to be "diabetes_linear...". |
|
The sir linear and sir standard came from your paper, the diabetes model was one which already existed. It's possible they're the same. |
|
Will hopefully be good after this... need to let tests finish and see, though |
|
Ok looks good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed sir_standard_stratification with a different hom import, renamed a variable in sir_linear_stratification. Overall, things worked pretty well.
In second commit, reran original examples. Had to do Graph = StockFlow.Graph a few times, as Catlab had a Graph which interfered. Fixed a few typos, converted a few comments to markdown.
All examples should be ok at this point.