Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicit Dispatch model type and @default_model macro #177

Open
wants to merge 1 commit into
base: not_implements
Choose a base branch
from
Open

Explicit Dispatch model type and @default_model macro #177

wants to merge 1 commit into from
+191 −18

Conversation

kris-brown
Copy link
Collaborator

Addresses #176

@kris-brown kris-brown added the enhancement New feature or request label Dec 9, 2024
@kris-brown kris-brown self-assigned this Dec 9, 2024
@kris-brown kris-brown linked an issue Dec 9, 2024 that may be closed by this pull request
Explicit models which just use type dispatch #176
Open
@codecov Codecov
Copy link

codecov bot commented Dec 9, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 73.33333% with 12 lines in your changes missing coverage. Please review.

Project coverage is 95.04%. Comparing base (3d4bf2c) to head (69dc438).

Files with missing lines Patch % Lines
src/models/ModelInterface.jl 70.00% 12 Missing ⚠️
Additional details and impacted files 
@@                Coverage Diff                 @@
##           not_implements     #177      +/-   ##
==================================================
- Coverage           95.48%   95.04%   -0.45%     
==================================================
  Files                  38       38              
  Lines                2258     2299      +41     
==================================================
+ Hits                 2156     2185      +29     
- Misses                102      114      +12

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kris-brown kris-brown mentioned this pull request Dec 9, 2024
Closed
@kris-brown kris-brown changed the base branch from main to not_implements December 9, 2024 21:52
@kris-brown kris-brown force-pushed the symbolic_model_explicit branch 3 times, most recently from 19d1841 to a7d785c Compare December 9, 2024 22:10
@kris-brown kris-brown force-pushed the symbolic_model_explicit branch from a7d785c to 69dc438 Compare December 12, 2024 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kris-brown kris-brown

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Explicit models which just use type dispatch
1 participant
@kris-brown