Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the Model abstract type, simplify model migration code. #172

Open
wants to merge 2 commits into
base: withmodel_subtype
Choose a base branch
from

Migrate models with theorymap modules, not theorymaps

86e6d51
Select commit
Loading
Failed to load commit list.
Open

Remove the Model abstract type, simplify model migration code. #172

Migrate models with theorymap modules, not theorymaps
86e6d51
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 12, 2024 in 0s

95.43% (target 90.00%)

View this Pull Request on Codecov

95.43% (target 90.00%)

Details

Codecov Report

Attention: Patch coverage is 93.65079% with 4 lines in your changes missing coverage. Please review.

Project coverage is 95.43%. Comparing base (be9b7d5) to head (86e6d51).

Files with missing lines Patch % Lines
src/models/ModelInterface.jl 93.18% 3 Missing ⚠️
src/syntax/gats/gat.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##           withmodel_subtype     #172      +/-   ##
=====================================================
- Coverage              95.56%   95.43%   -0.14%     
=====================================================
  Files                     38       38              
  Lines                   2234     2257      +23     
=====================================================
+ Hits                    2135     2154      +19     
- Misses                    99      103       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.