Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logic of @import #168

Open
wants to merge 1 commit into
base: md_fix
Choose a base branch
from
Open

Fix logic of @import #168

wants to merge 1 commit into from

Conversation

kris-brown
Copy link
Collaborator

@kris-brown kris-brown commented Dec 7, 2024

Addresses #167

This changes what @import does within the @instance macro. Rather than removing expected signatures, whenever we have leftover unimplemented signatures we check if the name of the method is in the imports and ignore the missing method error if so.

I've tested that this doesn't break Catlab.

@kris-brown kris-brown linked an issue Dec 7, 2024 that may be closed by this pull request
@kris-brown kris-brown self-assigned this Dec 7, 2024
Copy link

codecov bot commented Dec 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.56%. Comparing base (a129cb4) to head (1b42e18).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #168      +/-   ##
==========================================
+ Coverage   93.85%   95.56%   +1.70%     
==========================================
  Files          38       38              
  Lines        2229     2231       +2     
==========================================
+ Hits         2092     2132      +40     
+ Misses        137       99      -38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kris-brown kris-brown added the bug Something isn't working label Dec 9, 2024
@kris-brown kris-brown changed the base branch from main to md_fix December 9, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding a method with a theory extension breaks @instance
1 participant