Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import equations from AlgebraicInterfaces and bump version #152

Merged
merged 2 commits into from
Jun 18, 2024
Merged

Conversation

kris-brown
Copy link
Collaborator

Now that ACSets.jl exports equations, and Catlab inherits from both ACSets and GATlab, I have added equations to AlgebraicInteraces so that both ACSets and GATlab can extend the same function. This PR also bumps the version number so that we can cut a new minor release before integrating with Catlab.

@kris-brown kris-brown added the enhancement New feature or request label Jun 10, 2024
@kris-brown kris-brown self-assigned this Jun 10, 2024
Copy link

codecov bot commented Jun 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.52%. Comparing base (b304bf0) to head (a556868).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #152   +/-   ##
=======================================
  Coverage   94.52%   94.52%           
=======================================
  Files          38       38           
  Lines        2082     2082           
=======================================
  Hits         1968     1968           
  Misses        114      114           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@epatters epatters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR needs to bump the compat entry on AlgebraicInterfaces, right?

@kris-brown kris-brown merged commit 519d855 into main Jun 18, 2024
9 checks passed
@epatters epatters deleted the add_eqs branch June 18, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants