Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor scopes #115

Merged
merged 12 commits into from
Oct 9, 2023
Merged

Refactor scopes #115

merged 12 commits into from
Oct 9, 2023

Conversation

kris-brown
Copy link
Collaborator

We are making big changes.

@kris-brown kris-brown marked this pull request as draft September 28, 2023 00:33
@kris-brown
Copy link
Collaborator Author

did someone say Theory Maps?

@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Attention: 44 lines in your changes are missing coverage. Please review.

Comparison is base (ee4bf10) 96.74% compared to head (76cbd99) 96.20%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #115      +/-   ##
==========================================
- Coverage   96.74%   96.20%   -0.54%     
==========================================
  Files          28       34       +6     
  Lines        1690     1873     +183     
==========================================
+ Hits         1635     1802     +167     
- Misses         55       71      +16     
Files Coverage Δ
src/models/SymbolicModels.jl 97.46% <100.00%> (+0.09%) ⬆️
src/models/module.jl 100.00% <ø> (ø)
src/stdlib/theories/module.jl 100.00% <ø> (ø)
src/syntax/ExprInterop.jl 100.00% <100.00%> (ø)
src/syntax/GATContexts.jl 100.00% <100.00%> (ø)
src/syntax/GATs.jl 100.00% <ø> (+3.33%) ⬆️
src/syntax/TheoryInterface.jl 96.55% <100.00%> (+0.47%) ⬆️
src/syntax/module.jl 100.00% <ø> (ø)
src/models/ModelInterface.jl 99.13% <98.71%> (+0.82%) ⬆️
src/models/Presentations.jl 98.95% <98.95%> (ø)
... and 7 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kris-brown kris-brown marked this pull request as ready for review October 9, 2023 21:43
Copy link
Member

@olynch olynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@olynch olynch merged commit 94b9776 into main Oct 9, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants