Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add import statements to @theory declaration #107

Merged
merged 1 commit into from
Sep 21, 2023
Merged

add import statements to @theory declaration #107

merged 1 commit into from
Sep 21, 2023

Conversation

kris-brown
Copy link
Collaborator

This allows us to explicitly declare that the generated methods in the associated theory module extend some other methods.

@kris-brown kris-brown self-assigned this Sep 21, 2023
@kris-brown kris-brown requested a review from olynch September 21, 2023 00:06
Copy link
Member

@olynch olynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Patch coverage: 86.20% and project coverage change: -0.17% ⚠️

Comparison is base (15cec29) 96.84% compared to head (9117faf) 96.68%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #107      +/-   ##
==========================================
- Coverage   96.84%   96.68%   -0.17%     
==========================================
  Files          26       27       +1     
  Lines        1458     1477      +19     
==========================================
+ Hits         1412     1428      +16     
- Misses         46       49       +3     
Files Changed Coverage Δ
src/stdlib/models/module.jl 100.00% <ø> (ø)
src/syntax/GATs.jl 95.61% <80.00%> (-0.49%) ⬇️
src/syntax/TheoryInterface.jl 96.42% <88.88%> (-1.45%) ⬇️
src/models/ModelInterface.jl 97.63% <100.00%> (ø)
src/stdlib/models/Arithmetic.jl 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@olynch olynch merged commit d06ab56 into main Sep 21, 2023
8 of 9 checks passed
@kris-brown kris-brown deleted the extendmethod branch September 21, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants